Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tutor >= 17.0.0 (quince) #61

Closed
snglth opened this issue Jan 30, 2024 · 7 comments
Closed

Support tutor >= 17.0.0 (quince) #61

snglth opened this issue Jan 30, 2024 · 7 comments
Assignees

Comments

@snglth
Copy link

snglth commented Jan 30, 2024

Currently the version constraint in setup.py won't allow you to use harmony in tutor 17 projects. Is there anything that holds us from supporting tutor 17?

@jfavellar90
Copy link
Contributor

@snglth sorry for the late answer and thanks for reporting the issue. We are in the process of adding the proper support to the Harmony Tutor plugin. In the next few days, we'll proceed with the proper versioning of the plugin so it supports the latest Tutor version. We'll let you know once this is done

@jfavellar90
Copy link
Contributor

@snglth This is still WIP. There's a draft PR with the basic changes for Quince support, however, there are a couple of issues that need to be fixed before releasing the Quince-compatible version. We'll keep you posted about the progress on this task.

@gabor-boros
Copy link
Contributor

@jfavellar90 Could you please elaborate on what are the issues you are facing with? I'd be happy to help as I got blocked on this too.

@gabor-boros
Copy link
Contributor

@jfavellar90 or @felipemontoya do you have any insights?

@jfavellar90
Copy link
Contributor

Sorry @gabor-boros @farhaanbukhsh, my schedule was hectic in the last 2 weeks. I did a basic test of the plugin in Quince and from the configuration side of things, it's working OK as already confirmed in the PR (I don't remember exactly the reason of my previous failure). What's missing is testing the commands added by the plugin and check they're behaving as expected.

@gabor-boros
Copy link
Contributor

The related PRs #63 and #70 are merged. The latest version of the plugin will support Quince.

@farhaanbukhsh
Copy link
Member

@gabor-boros Thank you for taking care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants