-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration Testing Proposal #88
Comments
tagging you here as you are probably the ones more interested in this issue. @bradenmacdonald @gabor-boros @jfavellar90 |
I would also add that the integration test code itself should be something that's easy to maintain. If it's complex and fragile, it may not be worth the effort. |
Following this discussion, are there any specific scenarios we need to cover? The POC already has a test for ElasticSearch but I don't have any other scenarios in mind to test. |
For Sumac, we'll actually need Meilisearch instead of Elasticsearch :p |
Once support is added I will add the integration testing scenarios. Will the current implementation cover most of our use cases? I tested ClickHouse and ElasticSearch and found and resolved an issue with ElasticSearch disabled. We can also merge the integration testing PR and start adding scenarios as part of the new features/fixes. |
Is there anything blocking this PR, FYI only a small change is needed to the workflow so that any issues on the scripts will trigger a CI failure |
This discussion proposes a solution for the integration testing implementation on Harmony.
Requirements
Proposed solution
Kind runs k8s on a cluster and works pretty well for our purposes, this tool is already explored on Aspects integration tests. The POC implemented here #80 proposes a folder structure and a GitHub action workflow to test different configurations of the helm chart in parallel, a template for adding new integration testing scenarios, and an initial scenario to setup and test ElasticSearch.
The text was updated successfully, but these errors were encountered: