-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update K8s dashboard chart version #68
Conversation
Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
1 similar comment
Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
b83b163
to
93ec805
Compare
@felipemontoya this has been rebased. Now it can be reviewed anytime. |
@felipemontoya a gentle reminder here 😇 |
Hi @gabor-boros, sorry for taking so long. This PR makes absolute sense. It might be even late as there is now a 7.3.1 (completely fault of the late reviewer). I reviewed the notes from the package and it says:
Did you run into this when you did the change locally? Are we moderately confident that most installers won't have an issue? Maybe we should start the practice of leaving changenotes so there is a summary of operations made available for users. I don't think we should block the PR though. I will leave an approval in a moment. |
93ec805
to
9c6f9da
Compare
Signed-off-by: Gabor Boros <[email protected]>
9c6f9da
to
0e6dc75
Compare
Nice! I just updated the dependency before merging the PR to ensure the latest chart is used.
Yes I did. However, this only happens when someone wants to expose the dashboard using an ingress controller (and don't want to do port-forwarding). Since it wasn't available before to do anything else but port-forwarding, I'm quite confident that most people won't have issues. Also, I'm not even sure that many people using the Kubernetes dashboard, as it must be explicitly enabled.
That's a great idea! How about discussing that on the next meeting? I'd love to have some change notes. |
@gabor-boros 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR bumps the K8s chart version to the latest available, which provides TLS configuration options. Hence, we are able to set SSL certificates for service, and expose it.