Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying the skeleton component #2420

Closed
PKulkoRaccoonGang opened this issue Jul 5, 2023 · 5 comments
Closed

Displaying the skeleton component #2420

PKulkoRaccoonGang opened this issue Jul 5, 2023 · 5 comments
Assignees
Labels
bug Report of or fix for something that isn't working as intended raccoon-gang

Comments

@PKulkoRaccoonGang
Copy link
Contributor

After changing the background of the use cases on the documentation site, there was a problem with the display of loading bars in the Skeleton component.

image

image

@PKulkoRaccoonGang PKulkoRaccoonGang added raccoon-gang bug Report of or fix for something that isn't working as intended labels Jul 5, 2023
@adamstankiewicz
Copy link
Member

@PKulkoRaccoonGang Great catch. A couple thoughts here:

  1. Is this a bug only on the documentation website? Or is it also an issue for consumers of Skeleton (e.g., in MFEs)?
  2. Are we sure the issue is due to the changed background color of the code block previews?
    1. Presumably, the "With custom theme" example code snippet would have distinct background color from the background of the code block preview but it also does not appear.
    2. There was also a recent change related to how we import the CSS from react-loading-skeleton, which I feel may be more of the culprit to the regression we're now seeing in the documentation website. Looking at the deploy preview on that change to the CSS import, the skeleton loaders are not visible on the docs site, but a deploy preview for just 2 PRs earlier from that recent change, the skeleton loaders do appear on the colored background (/cc @davidjoy):
image

@adamstankiewicz
Copy link
Member

  1. Find solution.
  2. Verify in Gatsby docs site.
  3. Verify in example Paragon MFE.
  4. Check in consuming MFE.

@monteri monteri moved this from To Do to In progress in Paragon Working Group Aug 10, 2023
@adamstankiewicz
Copy link
Member

I believe this recently filed Card loading state issue will likely be resolved by this issue.

@PKulkoRaccoonGang
Copy link
Contributor Author

PKulkoRaccoonGang commented Aug 16, 2023

PR: #2584

@PKulkoRaccoonGang PKulkoRaccoonGang moved this from In progress to In review in Paragon Working Group Aug 16, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from In review to In progress in Paragon Working Group Aug 16, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from In progress to In review in Paragon Working Group Aug 16, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from In review to To Do in Paragon Working Group Aug 25, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from To Do to In progress in Paragon Working Group Aug 25, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from In progress to In review in Paragon Working Group Sep 11, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from In review to Done in Paragon Working Group Dec 8, 2023
@viktorrusakov
Copy link
Contributor

This was fixed in #2865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended raccoon-gang
Projects
Status: Done
Development

No branches or pull requests

4 participants