-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: selectable box set props forwarding #2461
Conversation
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2461 +/- ##
==========================================
+ Coverage 91.39% 91.42% +0.02%
==========================================
Files 234 234
Lines 4161 4161
Branches 1001 1001
==========================================
+ Hits 3803 3804 +1
+ Misses 351 350 -1
Partials 7 7
☔ View full report in Codecov by Sentry. |
e334a59
to
e33e56d
Compare
e33e56d
to
ef4466e
Compare
Changes in latest push:
|
BREAKING CHANGE: aria-label is required when not using aria-labelledby in the SelectableBoxSet component. An associated label for the component is a WCAG requirement.
ef4466e
to
f29e3e0
Compare
🎉 This PR is included in version 21.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This sets up the ability to forward props directly to the root element of the
SelectableBoxSet
component. This came up originally to enable to ability to provide anaria-labelledby
attribute to theSelectableBoxSet
. This will support adding other attributes should the need come up in the future.Deploy Preview
Preview of changes
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist