Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): OEP65. updating to react-intl 6.4.4 #2525

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

pedromartello
Copy link
Contributor

Description

Allowing a peer dependency to react-intl@^6.4. The current version @^5.25.1 is incompatible with Piral which is being used as a the base framework for OEP65 - currently still known as OEPXXXX.

@openedx-webhooks
Copy link

openedx-webhooks commented Aug 10, 2023

Thanks for the pull request, @pedromartello! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 10, 2023
@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ba845c1
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64de86f37f1ce40008a49683
😎 Deploy Preview https://deploy-preview-2525--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (df915c2) 91.65% compared to head (ba845c1) 91.65%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2525   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         236      236           
  Lines        4195     4195           
  Branches     1012     1012           
=======================================
  Hits         3845     3845           
  Misses        346      346           
  Partials        4        4           

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 16, 2023
@e0d
Copy link

e0d commented Aug 16, 2023

@pedromartello checks are 🟢 , Let us know when this is ready for review.

@e0d e0d added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Aug 16, 2023
@pedromartello
Copy link
Contributor Author

@e0d - Since the related PR in frontend-platform is failing until this PR is merged, I am going to mark it ready now.

@pedromartello pedromartello marked this pull request as ready for review August 16, 2023 21:44
@mphilbrick211 mphilbrick211 removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Aug 17, 2023
@mphilbrick211
Copy link

Hi @adamstankiewicz - would you mind taking a look at this? Thanks!

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json Outdated Show resolved Hide resolved
@adamstankiewicz adamstankiewicz merged commit 7e5b37d into openedx:master Aug 17, 2023
9 checks passed
@openedx-webhooks
Copy link

@pedromartello 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U released
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants