-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): OEP65. updating to react-intl 6.4.4 #2525
Conversation
Thanks for the pull request, @pedromartello! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2525 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 236 236
Lines 4195 4195
Branches 1012 1012
=======================================
Hits 3845 3845
Misses 346 346
Partials 4 4 ☔ View full report in Codecov by Sentry. |
@pedromartello checks are 🟢 , Let us know when this is ready for review. |
@e0d - Since the related PR in |
Hi @adamstankiewicz - would you mind taking a look at this? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pedromartello 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 21.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Allowing a peer dependency to react-intl@^6.4. The current version @^5.25.1 is incompatible with Piral which is being used as a the base framework for OEP65 - currently still known as OEPXXXX.