Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alpha] Changes in Nav tabs UI #2526

Closed
dcoa opened this issue Aug 11, 2023 · 3 comments
Closed

[alpha] Changes in Nav tabs UI #2526

dcoa opened this issue Aug 11, 2023 · 3 comments
Assignees

Comments

@dcoa
Copy link
Contributor

dcoa commented Aug 11, 2023

Bug

I've been testing Paragon alpha in different MFEs, one of them Authn, and the tabs in Nav Component have some differences between the production view and the alpha version.

nav-alpha.webm
Prod Alpha
border bottom widh 2px 3px
Focus no border border

The border-bottom has a strange end

Expected behavior:

nav-prod.webm
@adamstankiewicz
Copy link
Member

Thanks for reporting this issue, @dcoa! We've prioritized a fix for our next Paragon sprint.

@PKulkoRaccoonGang
Copy link
Contributor

PKulkoRaccoonGang commented Nov 7, 2023

@dcoa Thank you for your message. Just recently we carried out a small redesign of the Tabs component. Now the Tabs look according to the design developed by the Paragon team. Most likely, when you noticed the differences in the design of the Tabs, the production version did not yet have new changes.

@adamstankiewicz what do you think?

@PKulkoRaccoonGang PKulkoRaccoonGang moved this from To Do to In review in Paragon Working Group Nov 7, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this Nov 7, 2023
@viktorrusakov
Copy link
Contributor

This is result of Tabs redesign, closing this issues as this is the expected result (it's actually now on prod of edx.org as well)

@github-project-automation github-project-automation bot moved this from In review to Done in Paragon Working Group Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants