Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] Reverse values for the Stack directions #2627

Closed
PKulkoRaccoonGang opened this issue Sep 15, 2023 · 4 comments · Fixed by #2678
Closed

[BD-46] Reverse values for the Stack directions #2627

PKulkoRaccoonGang opened this issue Sep 15, 2023 · 4 comments · Fixed by #2678
Assignees

Comments

@PKulkoRaccoonGang
Copy link
Contributor

PKulkoRaccoonGang commented Sep 15, 2023

Consider adding reverse values for the Stack Component directions. Now we have "horizontal" | "vertical" directions, it would be useful to add "horizontal-reverse" | "vertical-reverse" directions. This way we will give Stack Component more flexibility (this can be very useful when positioning elements on tablet or mobile screens).

Vertical direction
image

Vertical-reverse direction
image

@adamstankiewicz
Copy link
Member

@PKulkoRaccoonGang [curious] Is your proposal to include additional options for the direction prop, i.e. horizontal-reverse and vertical-reverse? I'm wondering whether any other alternative props API ideas are worth considering. For example, perhaps there's still just horizontal and vertical, but then we could introduce a separate prop for inverse: true, or similar. Food for thought; curious to hear your opinion :)

@PKulkoRaccoonGang
Copy link
Contributor Author

PKulkoRaccoonGang commented Sep 22, 2023

@adamstankiewicz Yes, its my proposal. I think your idea is the better 🤔
Let's do it as you suggested, we will leave the horizontal and vertical directions and add a new reverse prop. What do you think?

@adamstankiewicz adamstankiewicz moved this from Backlog to To Do in Paragon Working Group Sep 22, 2023
@adamstankiewicz
Copy link
Member

@PKulkoRaccoonGang Adding a reverse prop sounds good to me!

@khudym
Copy link
Contributor

khudym commented Oct 2, 2023

PR: #2678

@viktorrusakov viktorrusakov linked a pull request Oct 2, 2023 that will close this issue
10 tasks
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from To Do to In progress in Paragon Working Group Oct 5, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in Paragon Working Group Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants