Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] Visibility of text in an example of using the Layout component #2637

Closed
PKulkoRaccoonGang opened this issue Sep 20, 2023 · 2 comments · Fixed by #2668
Closed

[BD-46] Visibility of text in an example of using the Layout component #2637

PKulkoRaccoonGang opened this issue Sep 20, 2023 · 2 comments · Fixed by #2668
Assignees
Labels
bug Report of or fix for something that isn't working as intended raccoon-gang

Comments

@PKulkoRaccoonGang
Copy link
Contributor

PKulkoRaccoonGang commented Sep 20, 2023

It is difficult to recognize the text in the example of using the Layout component on the Paragon documentation site.

Current state:
image

Proposal:
image

@PKulkoRaccoonGang PKulkoRaccoonGang added bug Report of or fix for something that isn't working as intended raccoon-gang labels Sep 20, 2023
@adamstankiewicz
Copy link
Member

@PKulkoRaccoonGang Let's just verify the foreground vs. background colors chosen here pass WCAG AA color contrast.

https://webaim.org/resources/contrastchecker/

@PKulkoRaccoonGang
Copy link
Contributor Author

PKulkoRaccoonGang commented Sep 29, 2023

@adamstankiewicz After checking the colors for the example Layout component on the Paragon documentation site, it was discovered that all background colors (#ff0000, #008000, and #0000ff) fail accessibility checks for the #454545 text color. Those color options that were offered earlier also turned out to be invalid.

PR with valid colors (according to WCAG) #2668

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended raccoon-gang
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants