Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code health] (DRAFT) Replacing the values of properties with Paragon variables #2809

Open
PKulkoRaccoonGang opened this issue Nov 14, 2023 · 0 comments
Labels
code health Proactive technical investment via refactorings, removals, etc. raccoon-gang

Comments

@PKulkoRaccoonGang
Copy link
Contributor

PKulkoRaccoonGang commented Nov 14, 2023

  1. In the ColorPicker component, I noticed that you can use the existing SCSS variables provided by the Paragon. It's a good idea to keep your code clean by using the provided Paragon variables as much as possible. The same problem with shadows in the Sheet component.

My screenshot is just a suggestion for replacing variables:

Screenshot 2023-11-14 at 13 12 44

  1. Move the $form-control-icon-width and $select-icon-padding variables to the appropriate variable file

  2. In the alpha version of Paragon, after transferring files from Bootstrap, you need to check and remove unnecessary comments if necessary

For example:
image

  1. Create a separate file for the IconButton component with variables and mixins and transfer there all the variables and mixins from the component’s styles file.

  2. Move the variables from the ProductTour (Checkpoint) component's general styles file to the variables file. It would also be nice to remove the “Override PopperJS arrow placement” comments, since it seems to me that it is obvious that the styles of this component are overriding the bootstrap styles (due to the use of !important).

  3. For an Scrollable component, it might be a good idea to add variables for key styles. We also have shadows provided by Paragon, which can also be used.

@PKulkoRaccoonGang PKulkoRaccoonGang added raccoon-gang code health Proactive technical investment via refactorings, removals, etc. labels Nov 14, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [code health] Replacing the values of properties with Paragon variables [code health] (DRAFT) Replacing the values of properties with Paragon variables Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Proactive technical investment via refactorings, removals, etc. raccoon-gang
Projects
None yet
Development

No branches or pull requests

1 participant