Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discovery] selection checkbox *inside* DataTable cards #2881

Open
brian-smith-tcril opened this issue Nov 30, 2023 · 3 comments
Open

[Discovery] selection checkbox *inside* DataTable cards #2881

brian-smith-tcril opened this issue Nov 30, 2023 · 3 comments

Comments

@brian-smith-tcril
Copy link
Contributor

Context

From slack:

Brian Smith Nov 16th 12:53 PM

In the UI/UX WG today the files page in the course authoring MFE was presented, and it's using a DataTable. One thing that was mentioned is that the designs called for the selection checkbox to be within the card, but it's currently implemented with the checkbox to the left https://github.com/openedx/frontend-app-course-authoring/blob/c5fc16b77a7a8930ba29[…]21f855618ba905aca870/src/files-and-videos/generic/FileTable.jsx

I feel like I remember a conversation about this in a WG meeting at some point, but I couldn't find any issues related to it. It seems (at least tangentially) related to the "Save for later" Icon button in the image cap stuff in figma.

Anyone remember if we already discussed this? If not I'll add something to the next agenda.

From Nov 29th WG meeting:

Jeff: Potentially problematic if the card is clickable (focusable things within focusable things)

Brian: will find the designs from UI/UX WG and bring them to WG next week

Gabe: Likes the pattern from a UI perspective, will look into previous WG notes and reach out to find context on why we didn’t implement this before

Designs from UI/UX WG

Figma: https://www.figma.com/file/RAZgifw9PnuO3e73ws6I6j/

image

@brian-smith-tcril
Copy link
Contributor Author

@gabew1984 friendly ping, just wondering if you managed to find any historical context on this one.

@brian-smith-tcril
Copy link
Contributor Author

usage guideline around clickable and checkbox in card to prevent what Jeff mentioned about focusable within focusable

@brian-smith-tcril
Copy link
Contributor Author

possible room for alignment with #2997, specifically the "compare" checkbox shown here

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant