Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local frontend-platform documentation #3063

Closed
2 tasks
chris1tapia opened this issue May 9, 2024 · 1 comment
Closed
2 tasks

Update local frontend-platform documentation #3063

chris1tapia opened this issue May 9, 2024 · 1 comment
Assignees

Comments

@chris1tapia
Copy link

chris1tapia commented May 9, 2024

Tasks

  1. design tokens
    PKulkoRaccoonGang
@kdmccormick kdmccormick closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
@sarina sarina transferred this issue from openedx/edx-platform May 15, 2024
@sarina sarina moved this from Done to Todo in Design Tokens Project Board May 15, 2024
@dcoa dcoa moved this from Todo to In Progress in Design Tokens Project Board May 30, 2024
@dcoa dcoa self-assigned this May 30, 2024
@dcoa
Copy link

dcoa commented May 30, 2024

I reviewed the documentation here https://github.com/openedx/frontend-platform/pull/689/files#diff-0e764ad3abf238c70590cbada2902ec481874e525cd7cd80da1a5875afda7d9a and made some improvements. Also, I checked the JSDoc to reflect the hook behavior, and with that, the gh-pages stay updated once the PR is merged. Finally, I made a small recommendation for the migrating document https://openedx.atlassian.net/wiki/spaces/BPL/pages/3770744958/Migrating+MFEs+to+Paragon+design+tokens+and+CSS+variables

@dcoa dcoa moved this from In Progress to To be reviewed in Design Tokens Project Board May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To be reviewed
Development

No branches or pull requests

3 participants