Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product Pull Request] fix: Fix discussions and notifications sidebars visibility with big amount of units #348

Closed
2 tasks
jmakowski1123 opened this issue Mar 28, 2024 · 6 comments

Comments

@jmakowski1123
Copy link

Copy link

Thanks for your submission, @openedx/open-edx-project-managers will review shortly.

@jmakowski1123 jmakowski1123 changed the title [Product Pull Request] [Product Pull Request] fix: Fix discussions and notifications sidebars visibility with big amount of units Mar 28, 2024
@jmakowski1123
Copy link
Author

Sometime between now and Sumac in December, we are very likely to be removing the horizontal navigation bar entirely in favor of the new lefthand sidebar nav, which will be released in Redwood. I'd suggest tabling this as it will be solved by default when we remove it.

@itsjeyd
Copy link

itsjeyd commented Apr 22, 2024

Hey @Lunyachek, considering @jmakowski1123's comment above, do you think it would make sense to close openedx/frontend-app-learning#1333 and openedx/frontend-app-learning#1334 (Quince backport)?

@jmakowski1123
Copy link
Author

I'm going to close this proposal from a product pov. If the new sidebar enhancements don't meet your needs by Sumac, we can revisit.

@itsjeyd
Copy link

itsjeyd commented Apr 26, 2024

@jmakowski1123 Just to understand better from a process perspective, does the ready for product review label still make sense for this feature ticket?

@itsjeyd itsjeyd added product review PR requires product review before merging and removed ready for product review labels May 31, 2024
@sarina
Copy link
Contributor

sarina commented Jun 4, 2024

Closing as this is marked "Abandoned" on the PR board. It may always be re-opened if needed.

@sarina sarina closed this as completed Jun 4, 2024
@itsjeyd itsjeyd removed the product review PR requires product review before merging label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: Abandoned
Development

No branches or pull requests

3 participants