-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add minimal readme to npm packages with rst readmes #215
Comments
Copying my comment from openedx/openedx-atlas#39. @brian-smith-tcril Based on my quick research, it looks like that npm doesn't support RST at all, while PyPi appears to support both RST and Markdown:
Popular packages such as React.js use Markdown: https://www.npmjs.com/package/react Some Open edX packages uses Markdown as well such https://www.npmjs.com/package/@edx/paragon while others don't as you pointed out for We have a couple of options:
I'm leaning towards using Markdown at least until npmjs has support for RST. I understand that RST is generally more powerful and concise (while Markdown can be flaky sometimes). However, it's helpful to see the full README within npmjs. If popular packages like React.js and paragon can get away with Markdown, I believe other npm-published packages can. I remember a decision to push for RST documentation, which is a good format for Sphinx docs and python tools but it seems that npmjs decides to keep it unsupported so it seems to worth a double check. |
I did a search for all npm packages in the
I also know we plan to publish MFEs on npm, which would require moving those over to md too
based on this, it seems moving to md is non-trivial but not impossible |
Currently, repos with rst readmes that are published to npm appear without a readme
https://www.npmjs.com/package/@edx/frontend-build
Since NPM doesn't support RST, we should use Markdown READMEs in those repositories. See this documentation decision for more details on why.
Once openedx/openedx-atlas#39 is resolved we will have a pattern to follow for other repos that have this issue.
Tasks
Relevant Repos
Note: This list might need to be refreshed if the time between this being written and it being picked up is more than a few weeks.
Currently Published to NPM
MFEs that will be published in the Future
Acceptance Criteria
The text was updated successfully, but these errors were encountered: