Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test cases after bot PR for updating python requirements #519

Merged
merged 2 commits into from
May 20, 2024

Conversation

salman2013
Copy link
Contributor

No description provided.

@salman2013 salman2013 changed the title Salman/fix test cases Fix test cases after bot PR for updating python requirements May 16, 2024
@salman2013 salman2013 requested a review from feanil May 16, 2024 10:48
@feanil
Copy link
Contributor

feanil commented May 16, 2024

Is a longer term fix to update https://github.com/openedx/repo-tools/blob/master/Makefile#L39 to also upgrade the py312 files?

@salman2013
Copy link
Contributor Author

@feanil I believe you are right but I was not sure about updating https://github.com/openedx/repo-tools/blob/master/Makefile#L39, there were some package version conflicts in extra-py312 file and i discussed with BOM team which created these files, they mentioned me to update the files locally with python 3.12 environment.
What if we merge this for now and let me update the make file separately?

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, let me know when this is out of draft and I can merge it.

@salman2013 salman2013 marked this pull request as ready for review May 20, 2024 07:20
@salman2013 salman2013 requested a review from feanil May 20, 2024 07:20
@salman2013
Copy link
Contributor Author

@feanil PR is ready to merge.

@feanil feanil merged commit a956a5a into openedx:master May 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants