Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify supported Node/NPM versions in engines property within package.json #171

Open
4 tasks
adamstankiewicz opened this issue Jun 27, 2023 · 0 comments
Open
4 tasks
Labels
epic Large unit of work, consisting of multiple tasks maintenance Routine upkeep necessary for the health of the platform

Comments

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Jun 27, 2023

Based on the discussion in this PR, we would like to consider adopting the following approach for managing Node.js version compatibility across micro-frontends.


Based on the guidance in this article, I believe what the author proposes for maintainers makes sense. We probably should be explicitly defining the supported Node.js version(s) in our repos/libraries with the engines property. I'd be curious to hear your thoughts, not just for this repository, but as a pattern more broadly.

{
  "engines": {
    "node": "^18",
    "npm": "^9"
  }
}
  • "When a Node.js version reaches end-of-life, even if your library is finished, bump a major version updating the engines field to the current oldest active LTS of Node.js."
  • "Consider throwing a helpful exception if your library is used on an unsupported Node.js version."
  • "Consider documenting your version support policy." See example from the aforementioned article.

Tasks

@adamstankiewicz adamstankiewicz added maintenance Routine upkeep necessary for the health of the platform epic Large unit of work, consisting of multiple tasks labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Large unit of work, consisting of multiple tasks maintenance Routine upkeep necessary for the health of the platform
Projects
Status: Backlog
Development

No branches or pull requests

1 participant