Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove edx-platform dependency on @edx/brand-edx.org #40

Open
davidjoy opened this issue Nov 22, 2021 · 0 comments
Open

Remove edx-platform dependency on @edx/brand-edx.org #40

davidjoy opened this issue Nov 22, 2021 · 0 comments
Labels
enhancement Relates to new features or improvements to existing features

Comments

@davidjoy
Copy link
Contributor

As a side effect of the way that edx-themes are loaded in edx-platform, we were required to add @edx/brand-edx.org as an explicit dependency in edx-platform when performing a rebranding of the edx.org site.

This is because a theme has no build of its own and cannot have any npm dependencies - it relies on the platform's node_modules, therefore any dependencies needed by the theme have to be added to the platform itself.

This task is to clean up this issue by finding a way to either give edx-themes dependencies or update the build process to allow brand substitution like we do with MFEs. This task will require a bit of discovery to figure out an appropriate way to accomplish this.

@arbrandes arbrandes added epic Large unit of work, consisting of multiple tasks enhancement Relates to new features or improvements to existing features and removed epic Large unit of work, consisting of multiple tasks labels Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Relates to new features or improvements to existing features
Projects
Status: Backlog
Development

No branches or pull requests

2 participants