Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct acs actions constant #398

Merged
merged 1 commit into from
Jul 27, 2023
Merged

fix: correct acs actions constant #398

merged 1 commit into from
Jul 27, 2023

Conversation

ilee2u
Copy link
Contributor

@ilee2u ilee2u commented Jul 27, 2023

Related to edx/edx-exams#154.

JIRA: https://2u-internal.atlassian.net/jira/software/projects/MST/boards/584?selectedIssue=MST-1961
Description

As of now, the ACS endpoint only supports a flag action. We would also like to support terminate as a way for Proctorio to communicate that they have ended an attempt.

Upon receiving a terminate request, the attempt referenced in the request should be moved to a corresponding status, depending on the reason for termination (reason_code) and incident_severity. The reason_code mappings should be clarified with Proctorio, and the incident_severity should be discussed internally to decide what range of values are considered passing.

Reason codes:

user_submission: move attempt to verified or second_review_required

error: move attempt to error

Severity:

we can just use a constant set to 0.25 for this at the moment

terminate with severity > 0.25 will move to second_review_required otherwise verified

Question: Do we want to store the reason code and incident severity in another model (similar to a review)?

work with dev on MST-1992: Return review info to exams-dashboard

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b9a0407) 97.89% compared to head (1af3d4e) 97.89%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          77       77           
  Lines        6399     6399           
=======================================
  Hits         6264     6264           
  Misses        135      135           
Flag Coverage Δ
unittests 97.89% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lti_consumer/lti_1p3/constants.py 100.00% <ø> (ø)
lti_consumer/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilee2u ilee2u merged commit 8c08abe into master Jul 27, 2023
6 checks passed
@ilee2u ilee2u deleted the ilee2u/fix-acs-actions branch July 27, 2023 19:19
@ilee2u ilee2u restored the ilee2u/fix-acs-actions branch July 27, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants