Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing external configuration error message #423

Conversation

kuipumu
Copy link
Contributor

@kuipumu kuipumu commented Oct 25, 2023

Description

This PR adds a fix for the LTI external configurations feature issue #420

Type of Change

  • Modify _get_lti_config_for_block function on plugin/api.py module to raise an ExternalConfigurationNotFound error when no external LTI configuration is found.

Testing

  1. Create a course and add a LTI consumer XBlock.
  2. Edit the XBlock settings and set "Configuration Type" to "Reusable Configuration".
  3. Edit the XBlock settings and set "LTI Reusable Configuration ID" to an nonexistent external configuration (Ex: test:test).
  4. Save the XBlock and reload the studio editor.
  5. The studio view should show an exception.
  6. Go to the learning MFE and load the unit where the XBlock is.
  7. The learning MFE should show an general unexpected exception.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 25, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 25, 2023

Thanks for the pull request, @kuipumu! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f36725a) 97.95% compared to head (291567b) 97.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   97.95%   97.93%   -0.02%     
==========================================
  Files          77       77              
  Lines        6686     6689       +3     
==========================================
+ Hits         6549     6551       +2     
- Misses        137      138       +1     
Flag Coverage Δ
unittests 97.93% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lti_consumer/api.py 97.91% <75.00%> (-1.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211
Copy link

Hi @kuipumu! Would you mind rebasing this pull request? Doing so might help resolve the codecov errors. If that doesn't work, I'll look into it for you. Thanks!

@mphilbrick211
Copy link

Hi @kuipumu! Would you mind rebasing this pull request? Doing so might help resolve the codecov errors. If that doesn't work, I'll look into it for you. Thanks!

Hi @kiram15! Friendly follow-up on this!

@mphilbrick211
Copy link

Hi @kuipumu! Just checking in to see if you plan to pursue this pull request?

@mphilbrick211
Copy link

Hi @kuipumu! I'm going to close this pull request for now, but we can reopen in the future if you'd like to pursue. Thanks!

@openedx-webhooks
Copy link

@kuipumu Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@mphilbrick211 mphilbrick211 added the closed inactivity PR was closed because the author abandoned it label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed inactivity PR was closed because the author abandoned it open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants