-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update xqueue_watcher.jailedgrader to comply with Python 3.12's removal of imp
module
#109
Conversation
…al of `imp` standard library module
Thanks for the pull request, @TheVinhLuong102! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 88.42% 88.56% +0.14%
==========================================
Files 6 6
Lines 475 481 +6
==========================================
+ Hits 420 426 +6
Misses 55 55 ☔ View full report in Codecov by Sentry. |
imp
standard library moduleimp
module
Hi @TheVinhLuong102, thank you for this contribution! I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard? |
Hey @TheVinhLuong102, just checking in to see if you're still planning to continue working on this PR? |
Hi @TheVinhLuong102! Just a quick update that we're closing this PR now because it is stale. You may reopen this pull request, or open a new one, when you have time to come back to this work. |
@TheVinhLuong102 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Python 3.12 has removed the
imp
standard library module.This PR updates certain code modules from using the deprecated
imp
to usingimportlib
functionalities instead.