Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update xqueue_watcher.jailedgrader to comply with Python 3.12's removal of imp module #109

Closed
wants to merge 2 commits into from

Conversation

TheVinhLuong102
Copy link
Contributor

Python 3.12 has removed the imp standard library module.

This PR updates certain code modules from using the deprecated imp to using importlib functionalities instead.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 8, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @TheVinhLuong102! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1aa0e58) 88.42% compared to head (ffcd93d) 88.56%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   88.42%   88.56%   +0.14%     
==========================================
  Files           6        6              
  Lines         475      481       +6     
==========================================
+ Hits          420      426       +6     
  Misses         55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheVinhLuong102 TheVinhLuong102 changed the title update xqueue_watcher.jailedgrader to comply with Python 3.12's removal of imp standard library module update xqueue_watcher.jailedgrader to comply with Python 3.12's removal of imp module Nov 8, 2023
@itsjeyd
Copy link

itsjeyd commented Nov 17, 2023

Hi @TheVinhLuong102, thank you for this contribution!

I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 17, 2023
@itsjeyd
Copy link

itsjeyd commented Dec 14, 2023

Hey @TheVinhLuong102, just checking in to see if you're still planning to continue working on this PR?

@itsjeyd itsjeyd added the inactive PR author has been unresponsive for several months label Dec 14, 2023
@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 21, 2023
@itsjeyd
Copy link

itsjeyd commented Jan 12, 2024

Hi @TheVinhLuong102! Just a quick update that we're closing this PR now because it is stale. You may reopen this pull request, or open a new one, when you have time to come back to this work.

@itsjeyd itsjeyd closed this Jan 12, 2024
@openedx-webhooks
Copy link

@TheVinhLuong102 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added closed inactivity PR was closed because the author abandoned it and removed inactive PR author has been unresponsive for several months labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed inactivity PR was closed because the author abandoned it open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants