feat: add python 3.12support #923
Conversation
| skipsdist = True | ||
|
|
||
| [pycodestyle] | ||
| max-line-length = 120 | ||
|
|
||
| [pytest] | ||
| DJANGO_SETTINGS_MODULE = xqueue.test_settings | ||
| django_settings_module = xqueue.test_settings |
There was a problem hiding this comment.
| django_settings_module = xqueue.test_settings | |
| DJANGO_SETTINGS_MODULE = xqueue.test_settings |
| @@ -13,7 +13,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| tox-env: [quality, django42] | |||
| python-version: [3.8] | |||
| python-version: ['3.8', '3.11'] | |||
There was a problem hiding this comment.
Let's add 3.12 as well since all IDAs will need to be updated to Python 3.12 eventually.
There was a problem hiding this comment.
Perhaps it should just be 3.12 since that is what is in the envlist for tox?
| @@ -1,12 +1,12 @@ | |||
| [tox] | |||
| envlist = py38-django{42},quality | |||
| envlist = py{38, 312}-django{42},quality | |||
There was a problem hiding this comment.
This should either include 3.11 so that both 3.11 and 3.12 are represented as commented in the GitHub workflow, or the workflow should change to be just 3.12.
| @@ -13,7 +13,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| tox-env: [quality, django42] | |||
| python-version: [3.8] | |||
| python-version: ['3.8', '3.11'] | |||
There was a problem hiding this comment.
Perhaps it should just be 3.12 since that is what is in the envlist for tox?
|
Will this close #926 as well? |
|
Hi folks, I'm working on this issue to make the Xqueue codebase run in Tutor with Python 3.12. I was wondering if you require any help to push this PR forward so it lands on master soon. It seems it requires just a few changes in the Python version testing matrix. Please let me know @UsamaSadiq @blarghmatey, I'll be more than happy to help. |
|
I don't have commit access to this repo to be able to modify this PR, but if it's helpful to open a new PR with the suggested fixes then I can do that in place of this one. |
|
@blarghmatey please feel free to open a new PR with the changes, for this repo, if it's possible we want it to be 3.8 and 3.12 compatible. If 3.12 works, we don't need it to also be testing on 3.11 |
|
It looks like @jfavellar90 has up a new version of this here: #932 |
|
Closing this one as we should try to review/update/land that one. |
For the details, check the issue openedx/public-engineering#233