Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import and connect generators #21

Closed
19 of 22 tasks
nesnoj opened this issue Aug 23, 2017 · 14 comments
Closed
19 of 22 tasks

import and connect generators #21

nesnoj opened this issue Aug 23, 2017 · 14 comments
Assignees

Comments

@nesnoj
Copy link
Member

nesnoj commented Aug 23, 2017

Implement import of generator, weather and timeseries datasets.
Tasks:

@nesnoj
Copy link
Member Author

nesnoj commented Sep 1, 2017

New geno mviews are considered in dingo by now, see openego/ding0#225.

@nesnoj
Copy link
Member Author

nesnoj commented Sep 22, 2017

Note: conv. genos are disregarded now, due to a bug in conv pp tables, see openego/data_processing#175

@nesnoj
Copy link
Member Author

nesnoj commented Sep 22, 2017

Notes:

  • new LV genos which are member of former agg. LA are added as 1 new agg. geno (unline the dingo importer, there're no type- or subtype-specific agg. genos)

@gplssm
Copy link
Contributor

gplssm commented Sep 22, 2017

When there is one aggr. Generation, neglecting its type, I don't know how to assign the according time series... Any suggestions for this?

@nesnoj
Copy link
Member Author

nesnoj commented Sep 24, 2017

Ok I will change this..

@nesnoj
Copy link
Member Author

nesnoj commented Sep 30, 2017

A question concerning cable selection procedure @birgits @gplssm :

To connect new genos I have to choose a cable type for line. Approach: Use the smallest possible cable available which is able to carry the max. apparent power (taking the load factor into account). If the power exceeds the max. available value, use the quantity attribute (same procedure here -> quantity * rated_power * load_factor > apparent power). Right?

In your parts, you have to select cables too - is there a generic function to do this? If not, I'll move mine to e.g. tools...

@birgits
Copy link
Collaborator

birgits commented Oct 2, 2017

For grid expansion there are only two possibilities. Either a parallel cable of the same kind is installed or if this isn't sufficient as many parallel standard cables as needed are installed. So to answer your question there is no function that chooses the smallest possible cable yet, but you did the same in dingo, right? Your equation is correct, though for lines we use current instead of power. Otherwise you'd have to know the line voltage to calculate S.

@nesnoj
Copy link
Member Author

nesnoj commented Oct 4, 2017

Your equation is correct, though for lines we use current instead of power. Otherwise you'd have to know the line voltage to calculate S.

Thanks for the hint!
The problem is: I do not have either (except the rated values), since I connect the genos prior to PF.
But I only need approximate values during the connection to select an sufficient cable. Sure, in the borderline case (decision on cable 1 or 2?) it may happen that I'd select a cable which is either somewhat too small or oversized, but I would not bother too much here (I've no idea how to obtain exact values here except doing an extra PF which is definitely no option..).

EDIT: Solved, new method. Cf. #45 (comment)

@birgits
Copy link
Collaborator

birgits commented Sep 26, 2018

@nesnoj should we keep this issue open as a reminder what's left to do here or are just conventional generators missing, in which case I would just make a new issue out of it? Is the ToDo list at the top up to date?

@birgits birgits removed this from the Release v0.0.4 milestone Sep 26, 2018
@nesnoj
Copy link
Member Author

nesnoj commented Aug 20, 2019

Is this one still current?
The to-do-list should be up to date from my end, but maybe some parts were fixed meanwhile (not by me).
If we wait a couple of months, most parts will get obsolete as the MaStR could be used.

@birgits
Copy link
Collaborator

birgits commented Aug 26, 2019

It is still relevant, mostly because conventional generators are not yet imported.
Time series from oedb can be assigned, so I crossed that off the list. Weather data is not yet imported but might be helpful, wherefore we can leave it as a possible ToDo.
About the operation strategy for conventional generators - in #16 we decided to not implement an operation strategy for conventional generators in edisgo, as it is implemented in etrago and time series for conventional generators will be handed over to edisgo. However, when edisgo is used stand-alone, it might be useful to provide something to have reasonable time series for dispatchable generators. @gplssm what do you think, should we leave this issue on the list?
I am not sure what's meant by "Remove genos used for testing". @nesnoj?

@gplssm
Copy link
Contributor

gplssm commented Aug 27, 2019

If we wait a couple of months, most parts will get obsolete as the MaStR could be used.

Exactly my favorite kind of humor 😁
But, maybe, data quality of MaStR isn't too bad

MaStr_Veroeffentlichung_Technologien_Einheitentyp_SMARD-2019_Vergleich.pdf

About the operation strategy for conventional generators - in #16 we decided to not implement an operation strategy for conventional generators in edisgo, as it is implemented in etrago and time series for conventional generators will be handed over to edisgo. However, when edisgo is used stand-alone, it might be useful to provide something to have reasonable time series for dispatchable generators.

The feature of determining dispatch of flexible power plants is planned to be included when OPF is implemented in eDisGo. But, we can remove it from the list respectively mark it as resolved as we have the option to provide data that determines the dispatch.

CAUTION: The voltage level of some existing genos may change due to changes in capacities! If so, disconnect old geno and create new one with updated voltage level! (see openego/data_processing#181 (comment))

This seems to me still important. I would propose to create a new issue for that.

Solve problem with changing IDs of conv. PP - dis- and reconnect! #59

Important. Still open. Issue exits. I deleted it.

Some of the tasks that are described above in the issue's description, I didn't understand. @nesnoj are this task still relevant and open?

  • Remove genos used for testing
  • Link genos, weather data, timeseries

I suggest to create new issues.

@birgits said that some flexible power plant technologies (i.e. biomass, CHP,...) aren't imported at the moment. If this is true, let's created an issue.

Info: Some other points were removed due to risk of pending forever.

@birgits
Copy link
Collaborator

birgits commented Aug 28, 2019

@birgits said that some flexible power plant technologies (i.e. biomass, CHP,...) aren't imported at the moment. If this is true, let's created an issue.

I am not totally sure as I don't fully understand what is done but in those lines a filter for renewable generators is set so that only solar and wind generators are retrieved and the import of conventional generators is commented. The reason why this is done is not mentioned. I guess the problem with conventional generators could be the changing IDs that are addressed in issue #59. But I can't think of a reason why e.g. biomass powerplants can't be imported.

@birgits
Copy link
Collaborator

birgits commented Jul 9, 2021

Filters are now removed and all types of generators imported. The issue can now be closed.

@birgits birgits closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants