Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.7.2 #290

Closed
2 tasks done
ClaraBuettner opened this issue Jun 4, 2020 · 10 comments
Closed
2 tasks done

Release 0.7.2 #290

ClaraBuettner opened this issue Jun 4, 2020 · 10 comments
Assignees

Comments

@ClaraBuettner
Copy link
Contributor

ClaraBuettner commented Jun 4, 2020

I commented all open PR to decide if we want to merge it, close it or keep it open.
Besides, I checked if other newer branches might be merged before this release and added one PR. The other branches are already part of open PR or should be added later (e.g. sclopf).
Looking at the open issues, I think we should

I will take a look at these problems and comment here when I found a solution.

In addition, it might be useful to refer to grid dataversion v0.4.6 which can be used only for etrago. I don't know where is the best place for this by now.

@ClaraBuettner
Copy link
Contributor Author

By implementing the fix in #286, I run into other installation problems which have to be fixed:

  • egoio has to be upgraded to v0.4.7 due to installation problems of egoio (see Pip install does not work anymore ego.io#78 and Fix oedialect dependency ego.io#81)
  • egoio needs (just like eGo) SQL Alchemy >= 1.2.0, while etrago currently needs SQlAlchemy == 1.1.4
  • pypsa v0.11.0 is not compatible to newest versions of pyomo and networkx, so we have to limit the version number. We could either do this in pypsa11fork or in etrago. I think it's easier to add this to etragos setup.py but adding to the pypsa fork would be cleaner. What do you prefer @ulfmueller ?

@ClaraBuettner
Copy link
Contributor Author

These problems are solved in #291
I decided to change the requirements of pyomo and networkx in etrago to avoid changes n pypsa fork. But I can change this.

@ulfmueller
Copy link
Member

A few minor comments:

  1. so we do not need the dependency link anymore? Or is it still one - just called differently? If there is none anymore we could/have to change the installation and leave out the "--process-dependency-links" part...
  2. I think it is cleaner to do the networkx and pyomo version thing in the pypsa fork. because if our fork does not work with the newer version the setup py there is not functional. I cannot see any problem to specify it in the pypsa fork. do you?

@ulfmueller
Copy link
Member

By the way, it would be nice if we could get rid of the fork for the release when we update pypsa. At least we could check if it would be possible by now. just to keep in mind. may be I create an issue for the release after this one...

@ClaraBuettner
Copy link
Contributor Author

A few minor comments:

1. so we do not need the dependency link anymore? Or is it still one - just called differently? If there is none anymore we could/have to change the installation and leave out the "--process-dependency-links" part...

Yes, we don't need the option --process-dependency-links anymore. There is a link to the fork on github in the requirments: 'pypsa @ git+https://github.com/openego/PyPSA.git@master#egg=pypsa-0.11.0fork'

2. I think it is cleaner to do the networkx and pyomo version thing in the pypsa fork. because if our fork does not work with the newer version the setup py there is not functional. I cannot see any problem to specify it in the pypsa fork. do you?

No there is no problem. I just thought we don't want to change the fork. I can add the requirements to pypsa fork.

@ulfmueller
Copy link
Member

Perfect. Can you adjust the installation instructions in that branch too then?

@ClaraBuettner
Copy link
Contributor Author

I just pushed it to PR #291

@ClaraBuettner ClaraBuettner changed the title Release 0.7.3 Release 0.7.2 Jun 8, 2020
@ulfmueller
Copy link
Member

I could not see that you changed the installation instructions. I did so now in feature/installation_dependencies. Or did I misunderstand s.th.?

@ClaraBuettner
Copy link
Contributor Author

You're right, I forgot to change the installation instructions

@ulfmueller
Copy link
Member

eTraGo 0.7.2 is released - also on pypi. As a hack for the dependency link to the pypsa fork one has to use the pip version 18.1. This is now also part of the documentation. In future, we will avoid to use the dependency link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants