Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI does not cover pull requests? #18

Closed
hartwork opened this issue Nov 3, 2023 · 9 comments · Fixed by #54
Closed

CI does not cover pull requests? #18

hartwork opened this issue Nov 3, 2023 · 9 comments · Fixed by #54

Comments

@hartwork
Copy link
Contributor

hartwork commented Nov 3, 2023

Hi!

The CI at https://github.com/openela/openela.org/blob/main/.github/workflows/hugo.yaml seems to only run when (a) pushed to master or (b) when manually triggered but not for pull requests. In that current setup, it will be possible for pull requests to break master and only notice that after merge. Is that beneficial and intended?

Best, Sebastian
@NeilHanlon
Copy link
Member

Definitely. We are going to be using prow as part of our CI for the entire organization, and this will be managed in a similar way.

Thank you for noticing and reporting this!

@hartwork
Copy link
Contributor Author

hartwork commented Nov 8, 2023

@NeilHanlon use of prow sounds a like a bigger migration? I think before a migrating to prow all it would take if wanted would be to:

Just an idea.

@NeilHanlon
Copy link
Member

You're right. I'll get to this today :)

@hartwork
Copy link
Contributor Author

hartwork commented Nov 1, 2024

@NeilHanlon any news?

1 similar comment
@hartwork
Copy link
Contributor Author

@NeilHanlon any news?

@NeilHanlon
Copy link
Member

I've been working on some changes here but haven't had time to implement them. I'm open to help if you'd like to work on it.

@hartwork hartwork mentioned this issue Nov 18, 2024
Merged
@hartwork
Copy link
Contributor Author

I'm open to help if you'd like to work on it.

@NeilHanlon here you go: #54

@hartwork
Copy link
Contributor Author

@NeilHanlon any thoughts on pull request #54?

1 similar comment
@hartwork
Copy link
Contributor Author

hartwork commented Dec 5, 2024

@NeilHanlon any thoughts on pull request #54?

NeilHanlon pushed a commit that referenced this issue Dec 19, 2024
@hartwork
Run hugo build CI for pull requests, too (fixes #18) (#54)
889590a 
* hugo.yaml: Limit deployment to manual trigger or pushes to the main branch

Signed-off-by: Sebastian Pipping <[email protected]>

* hugo.yaml: Run build for pull requests, too

Signed-off-by: Sebastian Pipping <[email protected]>

* hugo.yaml: Stop limiting the push build to the main branch

Signed-off-by: Sebastian Pipping <[email protected]>

---------

Signed-off-by: Sebastian Pipping <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run hugo build CI for pull requests, too (fixes #18) hartwork/openela-org-fork
2 participants
@NeilHanlon @hartwork