Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDKs should get the token exchange endpoint from the issuer's configuration #197

Closed
5 tasks
rhamzeh opened this issue Aug 31, 2023 · 2 comments
Closed
5 tasks

SDKs should get the token exchange endpoint from the issuer's configuration #197

rhamzeh opened this issue Aug 31, 2023 · 2 comments
Labels
dotnet-sdk Affects the C#/DotNet SDK enhancement New feature or request go-sdk Affects the Go SDK good first issue Good for newcomers java-sdk Affects the Java/Kotlin SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK

Comments

@rhamzeh
Copy link
Member

rhamzeh commented Aug 31, 2023

Originally reported by @stefanmilivojevic91 for the .NET SDK

Token endpoint path should be fetched from issuer's openid configuration (.well-known/openid-configuration) endpoint. AzureAD has oauth2/token for instance and OAuth2Client is unable to fetch access token using client credentials flow
@rhamzeh rhamzeh added enhancement New feature or request go-sdk Affects the Go SDK dotnet-sdk Affects the C#/DotNet SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK java-sdk Affects the Java/Kotlin SDK good first issue Good for newcomers labels Aug 31, 2023
@aaguiarz
Copy link
Member

Instead of reading it from the OpenID discovery endpoint, we can let users configure it directly, to avoid querying the endpoint.

@rhamzeh rhamzeh mentioned this issue Dec 16, 2023
Open
5 tasks
@rhamzeh
Copy link
Member Author

rhamzeh commented Jan 23, 2024

Duplicated by a newer issue: #238, closing in favour of that

@rhamzeh rhamzeh closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dotnet-sdk Affects the C#/DotNet SDK enhancement New feature or request go-sdk Affects the Go SDK good first issue Good for newcomers java-sdk Affects the Java/Kotlin SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK
Projects
SDKs and Tooling
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhamzeh @aaguiarz