Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug with EvalMultMutable* #906

Closed
yspolyakov opened this issue Nov 15, 2024 · 2 comments · Fixed by #934
Closed

Fix a bug with EvalMultMutable* #906

yspolyakov opened this issue Nov 15, 2024 · 2 comments · Fixed by #934
Assignees
@dsuponitskiy @yspolyakov
Labels
bug Something isn't working
Milestone
Release 1.3.0

Comments

@yspolyakov
Copy link
Contributor

See https://openfhe.discourse.group/t/evalmultmutable-and-evalmultmutableinplace-produces-wrong-results-for-bfvrns/1724 for details.
@yspolyakov yspolyakov added the bug Something isn't working label Nov 15, 2024
@yspolyakov yspolyakov added this to the Release 1.3.0 milestone Nov 15, 2024
@yspolyakov yspolyakov self-assigned this Nov 26, 2024
@yspolyakov
Copy link
Contributor Author

yspolyakov commented Jan 27, 2025 •
edited
Loading

Clarifications:

  • For BFV, we do not need to support EvalMultMutable(inPlace) as no automated adjustment of ciphertexts is typically not done in BFV.
  • EvalMultMutableIPlace should work for BGV and CKKS. There is potentially a bug in the implementation.
  • Make sure EvalMultMutable works for Ciphertext-Plaintext multiplications as well
  • Add unit tests for these methods for all modes of BGV and CKKS

@dsuponitskiy dsuponitskiy linked a pull request Jan 30, 2025 that will close this issue
Disabled mutable operations for BFV and added unit tests for CKKS and BGV mutable operations #934
Merged
@yspolyakov
Copy link
Contributor Author

There were no bugs with mutable methods in CKKS and BGV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsuponitskiy dsuponitskiy

@yspolyakov yspolyakov

Labels
bug Something isn't working
Projects
None yet
Milestone
Release 1.3.0
2 participants
@dsuponitskiy @yspolyakov