fix: Do not select logos with a value #684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix slack message
Two related issues with logo annotation:
Cause: Whether or not the logo has an annotation is not checked at this line:
hunger-games/src/pages/logos/LogoAnnotation.jsx
Line 192 in 31327c2
Solution: Add
&& logo.annotation_type === null && logo.annotation_value === null
Cause: Only whether or not there is a value is checked at this line:
hunger-games/src/pages/logos/LogoAnnotation.jsx
Line 207 in 31327c2
Solution: Add
&& logo.annotation_type === null