Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify picking the shop location process #568

Closed
serpico opened this issue May 2, 2024 · 7 comments · Fixed by #597
Closed

Clarify picking the shop location process #568

serpico opened this issue May 2, 2024 · 7 comments · Fixed by #597

Comments

@serpico
Copy link

serpico commented May 2, 2024

Problem

Currently picking the shop location can be tricky.

For the sake of example look up Leclerc Canteleu in the search bar, out of the 7 results I can navigate on the map and isolate 3, all located Rue du canal but I can't match them individually with the choices offered on the left.

Proposed solution

I thought maybe clicking on one blue tack would highlight the corresponding option/choice on the left but it didn't work that way.

Displaying, on the left ( where house is currently displayed ), amenity= or shop= value as stored in OSM could help in that case, being an OSM contributor/user I even thought displaying the OSM ID/OSM way ( 65403813 in that case ) would sort me out but that's not for everyone.

@raphodn raphodn transferred this issue from openfoodfacts/open-prices May 3, 2024
@serpico
Copy link
Author

serpico commented May 6, 2024

another test case

Input : Tang Frères, 48 avenue d'Ivry

1st pick : 2621636797

2nd pick, after figuring the first was not the appropriate one, zooming on the map and using the blue tack to choose : 2573626630

Actual location/Expected : 252814154

@raphodn
Copy link
Member

raphodn commented May 31, 2024

Thanks for the feedback ! I dug into the code, there'is indeed some small issues after switching Nominatim to Photon.

Current search results for Leclerc Canteleu
image

After some fixes + improvements
image

Will open a PR 👍

@serpico
Copy link
Author

serpico commented May 31, 2024

Thanks! displaying osm_tag really helps to clear the confusion.

@raphodn
Copy link
Member

raphodn commented May 31, 2024

Yeah it was actually a bug, I was showing the wrong key from the Photon data..

@raphodn
Copy link
Member

raphodn commented May 31, 2024

And I noted your other ideas in #37 ! Showing the OSM ID could be easy to do (as a settings options)

@raphodn
Copy link
Member

raphodn commented Jun 3, 2024

fyi @serpico i did the osm id display option in #600 (in prod)

@serpico
Copy link
Author

serpico commented Jun 3, 2024

fyi @serpico i did the osm id display option in #600 (in prod)

@raphodn Yeah I saw it during the WE I think thanks again!!

I thought about something else but I'm not sure it's useful or really improve the user experience that's why I'm reluctant to open a specific issue for it, so this is just in case you see it.

In the location search page when the user change the zoom level or the bounding box of the map, trim the results on the left of the page accordingly to display only the markers visible on the map, could make it it easier to pick the relevant location.

Example, in that case on the left side, the 5 initials results would be trimmed to the 3 corresponding to the markers on the map would be displayed on the left.
trim results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants