Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof: link a date, location & currency #634

Closed
raphodn opened this issue Jun 19, 2024 · 6 comments · Fixed by #631, #639, #640, #645 or #648
Closed

Proof: link a date, location & currency #634

raphodn opened this issue Jun 19, 2024 · 6 comments · Fixed by #631, #639, #640, #645 or #648

Comments

@raphodn
Copy link
Member

raphodn commented Jun 19, 2024

Story

In the backend we're adding new fields to the Proof model

We can now improve the price add form to ask first for the proof + date + location + currency.
This will simplify price addition afterwards (pre-fill form, quality check on price data, ...)

This is valid for RECEIPT & PRICE_TAG proofs

@teolemon
Copy link
Member

Next, we need Open Prices to aggressively nudge you if you haven't inputed prices on all of your receipts :-)

@raphodn raphodn changed the title Link a date & location to a proof Proof: link a date, location & currency Jun 19, 2024
@raphodn
Copy link
Member Author

raphodn commented Jun 19, 2024

@monsieurtanuki in the next few days i will focus on integrating these new Proof fields.

  • the UI will change a bit, we'll be asking first the proof data, and then allow adding prices (slightly more proof-oriented)
  • if a user selects an existing proof with these info, the form will be pre-filled (and the fields set as readonly)
  • new info will be displayed under each proof, and possibility to order & filter as well
  • futur step will be to send these proofs to Proof: send to Google Cloud Vision, and store the matching JSON output open-prices#320 and get extra data (and one day pre-fill these info automatically)

@raphodn
Copy link
Member Author

raphodn commented Aug 17, 2024

Closing as this is completed in the web frontend.

Hopefully it will be integrated soon in the mobile app 🙏

@monsieurtanuki
Copy link
Collaborator

@raphodn Already coded in off-dart (openfoodfacts/openfoodfacts-dart#946) and Smoothie (openfoodfacts/smooth-app#5480)

@raphodn
Copy link
Member Author

raphodn commented Aug 21, 2024

@raphodn Already coded in off-dart and Smoothie

ok ! what got me confused is that its not yet in the released mobile app, as i still see new proofs uploaded without this info 👀

@monsieurtanuki
Copy link
Collaborator

ok ! what got me confused is that its not yet in the released mobile app, as i still see new proofs uploaded without this info 👀

@raphodn I believe it is in the latest released mobile app. Some users are still using the previous version anyway: this is an app, not the web ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment