Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same EAN different weight how to handle ? #913

Open
serpico opened this issue Oct 2, 2024 · 5 comments
Open

Same EAN different weight how to handle ? #913

serpico opened this issue Oct 2, 2024 · 5 comments

Comments

@serpico
Copy link

serpico commented Oct 2, 2024

Description

Pretty sure it came up already, 2860050040672 , there's a slight variation in weight ( 1337g in the OFF product's picture, 1242g in the picture I took today ) which would skew the weight per kilo, it feels like it should be handled like a "category" product by inputting the price per quantity when entered in OP but they use the same EAN...it's great for price tracking but I think also ripe for data quality issues, especially with casual users.

P_20241002_085220

@raphodn
Copy link
Member

raphodn commented Oct 2, 2024

I'm pretty sure barcodes that start with a 2 are "shop-weight specific".
So we'll probably have to nudge users to add them via category instead indeed

@serpico
Copy link
Author

serpico commented Oct 2, 2024

And it's gonna be a double whammy since the parent category is not yet included in #262.

Image

Should the script https://github.com/openfoodfacts/open-prices-frontend/blob/master/data/categories/filter_categories.py be in the wiki ?

Based on based on what you said about EAN starting with a 2 should all of them ( for example https://fr.openfoodfacts.org/categorie/foie-de-poulet ) be reprocessed ?

Would you still favor tweaking the script/filter/list on a one by one basis, essentially waiting for someone to request a product which doesn't show up when typed in the category box ? or should we add more in one go and run the risk of having too long a list ?

@raphodn
Copy link
Member

raphodn commented Oct 2, 2024

I'll let @aleene answer that one ^^

@aleene
Copy link

aleene commented Oct 3, 2024

You can always add a product with a barcode. Note that these are internal barcodes which can represent different products for different shops. Barcodes with enocoded weights are not yet supported. I assume that there is an issue already open for this.

@serpico
Copy link
Author

serpico commented Oct 8, 2024

see also https://prices.openfoodfacts.org/products/2644188023291 identical EAN weight varying wildly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants