Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an Eco-Score helper #191

Open
Tracked by #218
teolemon opened this issue Jul 20, 2021 · 6 comments
Open
Tracked by #218

Add an Eco-Score helper #191

teolemon opened this issue Jul 20, 2021 · 6 comments
Labels
🌱 Eco-Score 🛣️ Road to scores

Comments

@teolemon
Copy link
Member

teolemon commented Jul 20, 2021 •
edited
Loading

What

image
I specced a system to help 3rd party apps ask for relevant Eco-Score data. How about creating the logic within openfoodfacts-dart so that it can be reused easily ?

Eco-Score for 3rd party apps

A similar system for Eco-Score, and another one for Ingredient related analysis (NOVA, allergens, gluten…) would unlock more reuses, and more data for Open Food Facts

Will unlock
@monsieurtanuki
Copy link
Contributor

My suggestion would be to:

  1. create an enum with all the possible message cases (ProductImprovement?)
  2. for each message case, provide a (default) message in English
  3. add a method in Product that returns a List<ProductImprovement>
  4. the developer would then be able to ignore those possible improvements (same as today), to display them with the default English message, or to localize them according to their own user target and their own UI/UX

Same method for #193 of course.

@teolemon Does that make sense?

@teolemon teolemon mentioned this issue Aug 20, 2021
Closed
1 task
@teolemon
Copy link
Member Author

That looks like a rather good plan. I would also try to mutualize translations, or possibly move them to something on the server (a file the plugin could query ?)

@monsieurtanuki monsieurtanuki self-assigned this Aug 20, 2021
@monsieurtanuki
Copy link
Contributor

@teolemon Are you sure about the 'en:labels-to-be-completed' string?
In the unit tests I could not find a product with something similar. I found something like that for product.statesTags:

  • en:to-be-completed
  • en:nutrition-facts-completed
  • en:ingredients-completed
  • en:expiration-date-completed
  • en:packaging-code-to-be-completed
  • en:characteristics-to-be-completed
  • en:origins-to-be-completed
  • en:categories-completed
  • en:brands-completed
  • en:packaging-completed
  • en:quantity-completed
  • en:product-name-completed
  • en:photos-to-be-validated
  • en:packaging-photo-to-be-selected
  • en:nutrition-photo-selected
  • en:ingredients-photo-selected
  • en:front-photo-selected
  • en:photos-uploaded

monsieurtanuki added a commit to monsieurtanuki/openfoodfacts-dart that referenced this issue Aug 20, 2021
@monsieurtanuki
feature/openfoodfacts#191 - added and computed possible product impro…
e20fa4d 
…vements

Impacted files:
* `api_getProduct_test.dart`: added checks for `getProductImprovements`
* `Product.dart`: create `enum ProductImprovement` and `Product.getProductImprovements()`
@teolemon teolemon mentioned this issue Aug 23, 2021
Open
@stephanegigandet
Copy link
Contributor

There's no label to be completed state because some products don't have labels.

monsieurtanuki added a commit to monsieurtanuki/openfoodfacts-dart that referenced this issue Sep 2, 2021
@monsieurtanuki
feature/openfoodfacts#191 - but without "LABELS_TO_BE_COMPLETED"
41e7cea
@monsieurtanuki
Copy link
Contributor

@stephanegigandet I've just removed ProductImprovement.LABELS_TO_BE_COMPLETED from #217.

monsieurtanuki added a commit that referenced this issue Sep 16, 2021
@monsieurtanuki
Merge pull request #217 from monsieurtanuki/feature/#191
89c4e12 
feature/#191 - added and computed possible product improvements
@monsieurtanuki
Copy link
Contributor

Product improvements are now computed in product.getProductImprovements() (#217).
Beyond the enum values, I don't know how the translations are supposed to be integrated, and how.

@monsieurtanuki monsieurtanuki mentioned this issue Oct 1, 2021
Closed
monsieurtanuki added a commit to monsieurtanuki/openfoodfacts-dart that referenced this issue Nov 4, 2021
@monsieurtanuki
feature_2/openfoodfacts#191 - added eco-score and nutri-score categor…
0e06505 
…ies (ProductImprovement)

Impacted file:
* `Product.dart`
monsieurtanuki added a commit that referenced this issue Nov 12, 2021
@monsieurtanuki
feature_2/#191 - added eco-score and nutri-score categories (ProductI…
797339d 
…mprovement) (#288)

Impacted file:
* `Product.dart`
@monsieurtanuki monsieurtanuki mentioned this issue Nov 12, 2021
Merged
@teolemon teolemon mentioned this issue Dec 31, 2021
Closed
12 tasks
@teolemon teolemon mentioned this issue Feb 2, 2022
Closed
1 task
@teolemon teolemon mentioned this issue Mar 25, 2022
Closed
4 tasks
@monsieurtanuki monsieurtanuki removed their assignment Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🌱 Eco-Score 🛣️ Road to scores
Projects
Dart package - Support for new APIs and issues
Status: To do
🧃🛠️ Open Food Facts SDK tracking
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teolemon @stephanegigandet @monsieurtanuki