Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New web folder structure for images #983

Closed
teolemon opened this issue Oct 8, 2024 · 1 comment · Fixed by #984
Closed

New web folder structure for images #983

teolemon opened this issue Oct 8, 2024 · 1 comment · Fixed by #984
Assignees

Comments

@teolemon
Copy link
Member

teolemon commented Oct 8, 2024

          @monsieurtanuki @teolemon 

the server still support the old paths, but yes we should update the logic in the Dart package.

/// * 12345678 for barcode 12345678
/// * 123/456/789 for barcode 123456789

That will impact only the EAN8, of course.

Also others, e.g. 9 digit 123456789 is now in 000/012/345/6789. We not only split the EAN8, when we compute paths, we pad all codes with 0s so that they have 13 digits.

Originally posted by @stephanegigandet in openfoodfacts/openfoodfacts-infrastructure#363 (comment)

@monsieurtanuki
Copy link
Contributor

@teolemon already coded in #984, ready for review.

@monsieurtanuki monsieurtanuki self-assigned this Oct 9, 2024
@monsieurtanuki monsieurtanuki linked a pull request Oct 9, 2024 that will close this issue
@monsieurtanuki monsieurtanuki changed the title @monsieurtanuki @teolemon New web folder structure for images Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants