Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tagify SCSS file for styling of tag inputs #10030

Open
hangy opened this issue Mar 26, 2024 · 1 comment · May be fixed by #10063
Open

Use tagify SCSS file for styling of tag inputs #10030

hangy opened this issue Mar 26, 2024 · 1 comment · May be fixed by #10063
Labels
good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign.

Comments

@hangy
Copy link
Member

hangy commented Mar 26, 2024

Description

We currently include the default layout of tagify by copying the original CSS file from the npm package in gulp. However, the tagify package also provides a source SCSS file. It would be interesting to use the SCSS file instead and adapt the styling to our new website design.

Proposed Solution

  1. Use tagifies' SCSS file as a modifiable base instead of the pre-built CSS file
  2. Update the styling to match our new website design.

Benefits

  • Consistent styling with our website design.
  • Easier maintenance and customization using SCSS.

Implementation Steps

  1. Create a new SCSS file, which included the tagify SCSS file.
  2. Use that SCSS file instead of the CSS file in Gulp, so it's copied to css/dist/tagify.css during build
  3. Update the styling as needed.

Additional Notes

  • Ensure compatibility with other components and styles in our project.
@hangy hangy added good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. labels Mar 26, 2024
@hangy hangy changed the title design: Use tagify SCSS file for styling Use tagify SCSS file for styling of tag inputs Mar 26, 2024
@IsaiahLevy
Copy link

Can I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign.
Projects
Status: To discuss and validate
Development

Successfully merging a pull request may close this issue.

2 participants