Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import GS1 GDSN data format from Alnatura GmbH #10554

Closed
stephanegigandet opened this issue Jul 16, 2024 · 0 comments · Fixed by #10556
Closed

Import GS1 GDSN data format from Alnatura GmbH #10554

stephanegigandet opened this issue Jul 16, 2024 · 0 comments · Fixed by #10556
Assignees
@stephanegigandet
Labels
GS1 The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes. 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers

Comments

@stephanegigandet
Copy link
Contributor

We received a sample GDSN message from Alnatura, which is a bit different from Equadis. We need to change the GS1.pm module to support it.

First differences spotted:

  • a lot of fields are specified without the module name, e.g. foodAndBeverageIngredientModule vs food_and_beverage_ingredient:foodAndBeverageIngredientModule
  • some fields can be arrays where we expect a hash:
    "transaction" : {
    "documentCommand" : {
    "catalogue_item_notification:catalogueItemNotification" : [
@stephanegigandet stephanegigandet added the 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers label Jul 16, 2024
@stephanegigandet stephanegigandet self-assigned this Jul 16, 2024
@github-project-automation github-project-automation bot moved this to To discuss and validate in 🍊 Open Food Facts Server issues Jul 16, 2024
@teolemon teolemon added the GS1 The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes. label Jul 16, 2024
alexgarel pushed a commit that referenced this issue Jul 16, 2024
fix: GDSN import from Alnatura #10554
b8b684d
@stephanegigandet stephanegigandet mentioned this issue Jul 16, 2024
Merged
stephanegigandet added a commit that referenced this issue Jul 23, 2024
@stephanegigandet
fix: GDSN import from Alnatura (#10556)
6e2673a 
Fixes #10554
:

GDSN XML files can be formatted in different ways, leading to different
JSON files after conversion.

This PR:
- adds support for multiple notification inside a command
- adds support for tags that don't include the namespace

---------

Co-authored-by: OFF <[email protected]>
@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Jul 23, 2024
@github-project-automation github-project-automation bot moved this from Triage needed to Done in 🏭 Producers Platform Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanegigandet stephanegigandet

Labels
GS1 The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes. 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers
Projects
🍊 Open Food Facts Server issues
Archived in project
🏭 Producers Platform
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: GDSN import from Alnatura openfoodfacts/openfoodfacts-server
2 participants
@teolemon @stephanegigandet