Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script to load historic events into off-query doesn't recognise deleted products #10789

Closed
john-gom opened this issue Sep 13, 2024 · 0 comments · Fixed by #10791
Closed

Script to load historic events into off-query doesn't recognise deleted products #10789

john-gom opened this issue Sep 13, 2024 · 0 comments · Fixed by #10791

Comments

@john-gom
Copy link
Contributor

What

  • product_revision_to_historical_events.pl is looking for hard-coded text in the comment but this isn't always the same

Steps to reproduce the behavior

  1. Delete a product and do not use the word "Deleting product" in the comment
  2. Run the script
  3. See that no deleted event is created

Expected behavior

  • Should be using the deleted property from the product
@github-project-automation github-project-automation bot moved this to To discuss and validate in 🍊 Open Food Facts Server issues Sep 13, 2024
@john-gom john-gom linked a pull request Sep 13, 2024 that will close this issue
fix: Determine obsolete and deleted from the product revision #10791
Merged
@john-gom john-gom mentioned this issue Sep 13, 2024
Merged
stephanegigandet pushed a commit that referenced this issue Sep 13, 2024
@john-gom
fix: Determine obsolete and deleted from the product revision (#10791)
508d767 
Signed-off-by: John Gomersall <[email protected]>

### What

Use the product revision to determine delete and obsolete status

- Fixes #10789

---------

Signed-off-by: John Gomersall <[email protected]>
@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Determine obsolete and deleted from the product revision openfoodfacts/openfoodfacts-server
1 participant
@john-gom