Photo Drag & Drop causes photo to be uploaded 3 times

[teolemon]

What

1. Drag and drop a photo once.
2. Get 3 multiple uploads of the same photo.

Part of

• ✏️ Editing (Tracker) #5525

Screenshot

[sashabrava]

@teolemon, I've noticed the same thing on couple of my products, but the reason is different. Here's an example
https://world.openfoodfacts.org/cgi/product.pl?type=edit&code=5900783003968

The issue happened after I opened "Edit a product" Activity on Android application and pushed on the product picture. Pushing opened a dialog for cropping image, and confirming the cropping (even if you don't change image borders) creates a new file, and that's how duplicated files start to appear.
Android version: 5.1.1
App version: 3.2.3

I can send a screenshot if needed.
Or forward the issue to https://github.com/openfoodfacts/openfoodfacts-androidapp cause duplicated image is invisible for Android app.

[stephanegigandet]

Confirmed @teolemon 's bug. It happens only with drag and drop, which also seems to cause other issues like selecting some of those images for the new_lc language...

10 janvier 2020 à 12:24:48 CET - stephane Images sélectionnées (Ajout : ingredients_new_lc) - new image ingredients_new_lc : 5.16 - voir
10 janvier 2020 à 12:24:48 CET - stephane Images sélectionnées (Ajout : nutrition_new_lc) - new image nutrition_new_lc : 3.15 - voir

Probably some weird javascript bug with drag and drop + the file upload library.

[nazimboudeffa]

Can someone explain where is the bug exactly please, because I don't know where to drop the image

Because as its been sometime I stopped to watch the repo because of some reasons that has nothing to do with it and I just follow the javascript channel on slack in case there is bug, this one for instance

So, I don't remember haveing to upload an image with drag and drop from that time and when I connect to the site it displays the same interface as a while before

[stephanegigandet]

@nazimboudeffa the interface has not changed, but it is possible to drag and drop images on the upload image button. Some people use it even though it is not advertised.

[nazimboudeffa]

@stephanegigandet I just have uploaded an image and it didn't hapened maybe it's not on this button ? When does it happen @teolemon ?

[teolemon]

In that case, that was a product without barcode

[github-actions]

Stale issue message

[Telperion87]

In my case it is often way more than 3 times. For sure it happens by drag and dropping, but if I'm not wrong it also happened by trying with the button "add an image".

in this case it has been uploaded 7 times. The unconveniet thing is that when I try to delete some of them, it deletes more photos than selected, even all of them. And when it happens it's a problem because
it won't let you upload the exact same photo because it someway still sees it on the DB.

[teolemon]

August 25th 2021
Still here

[joepie91]

This just happened for me as well (but 7 times, in my case!), on https://world.openfoodfacts.org/product/8713305815805/tea-lemon-citrus-becky-s - Firefox 119.0 (64-bit) on NixOS 23.05.4853.d4b5a67bbe9e. I indeed dragged a photo from my photo viewer (Gwenview) onto the "Add a picture" button.

[alexgarel]

I think this is a bug related to jqueryfileupload.

Relevant code is in html/js/product-multilingual.js ( $('#imgupload_' + id).fileupload({)