Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to set image to exact copy of another language #368

Open
hangy opened this issue Jul 19, 2016 · 2 comments
Open

Provide option to set image to exact copy of another language #368

hangy opened this issue Jul 19, 2016 · 2 comments
Assignees
Labels
✂️ Editing - Images - Cropping ✏️ Editing 🌍 Multilingual products Product name, Generic name, Ingredients, Packaging text are multilingual fields. P3

Comments

@hangy
Copy link
Member

hangy commented Jul 19, 2016

For example with http://world.openfoodfacts.org/product/8712100872600/?rev=18, the product has multilingual packaging that only differs regarding the ingredients. The front image and nutrition table are identical. With the current multilingual approach, the user has to select and cut the front image and nutrition table for every language that exists on the packaging.

This not only leads to nearly duplicate images - there will be unnecessary differences between the languages because of manual cropping - and thus wasted space and crawler impact, but also leads to unnecessary work. I think would be better if an image - in this case front and nutrition - for a language could be linked to another language. The image URL used on the product opener instance should be the same for all languages.

I'm undecided on how to best implement this, as changing one front image could change all other languages' front image. This may or may not be done intentionally.

Part of

@hangy hangy added the 🌍 Multilingual products Product name, Generic name, Ingredients, Packaging text are multilingual fields. label Jul 19, 2016
@hangy hangy added this to the Multilingual Products milestone Jul 19, 2016
@stephanegigandet
Copy link
Contributor

The solution is to not select an image for the extra languages: the main language image will be used.

So maybe what we could do is to make this behavior clear in the product edit form, and to show the main language image by default on the other language tab. With some language like "Showing the selected image for German, you can select a different image for Italian if needed".

@teolemon teolemon removed the 🎯 P1 label Feb 16, 2017
@teolemon teolemon added ✨ Feature Features or enhancements to Open Food Facts server and removed ✨ Feature Features or enhancements to Open Food Facts server labels May 3, 2017
@hangy
Copy link
Member Author

hangy commented Feb 27, 2019

The solution is to not select an image for the extra languages: the main language image will be used.

The picture with the additional languages may not need to be the main language image. For example, a main nutrition table could be in English but a secondary nutrition table could contain texts in French, Dutch, and German. In that case, setting the nutrition table image for the latter three languages to the same file would be more efficient than cropping the image three times and storing three different images with roughly the same content.

@hangy hangy removed their assignment Jul 5, 2019
@teolemon teolemon removed the ✨ Feature Features or enhancements to Open Food Facts server label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✂️ Editing - Images - Cropping ✏️ Editing 🌍 Multilingual products Product name, Generic name, Ingredients, Packaging text are multilingual fields. P3
Projects
Status: To discuss and validate
Development

No branches or pull requests

3 participants