Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create placeholder response if the product is present on Open (Beauty/PetFood/Products) Facts #497

Open
Tracked by #5555 ...
teolemon opened this issue Sep 26, 2016 · 5 comments
Labels
API Read - Product API READ All READ APIs include Product, Search… API Refactor API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🎯 P1

Comments

@teolemon
Copy link
Member

teolemon commented Sep 26, 2016

What

Web:

  • Add a link to the product on Open (Beauty/PetFood/Products) Facts
  • Do not make the placeholder indexable

Mobile:

  • Send back a product with title: "Present on Open Beauty Facts" and the OBF url as URL on official site?

Technical decision

Part of

@hangy hangy added the ✨ Feature Features or enhancements to Open Food Facts server label Nov 15, 2016
@hangy
Copy link
Member

hangy commented Nov 15, 2016

Right now, this stuff runs on the same server, so some hacks could make this easy, but for long-term support (and possibly to support other future projects), this would need some "interwiki" like feature/API right? This probably also applies #319 and #320.

@teolemon teolemon modified the milestone: Open Beauty Facts Dec 15, 2016
@teolemon teolemon added the API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) label Dec 18, 2016
@teolemon teolemon added the 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org label Jan 24, 2017
@VaiTon VaiTon removed this from the Open Beauty Facts milestone Jun 23, 2019
@teolemon
Copy link
Member Author

teolemon commented Jun 5, 2020

Yes, long term, we need a decent system. But a hack would be very useful to improve the mobile user experience (at the minimum propose to install Open Beauty Facts on iPhone, or even customize behaviour (on Android))

@teolemon
Copy link
Member Author

teolemon commented Jun 5, 2020

Just checking a .sto file exists in the OBF file system and returning cosmetic=true would be enough for the mobile teams to solve the issue.

@teolemon
Copy link
Member Author

This could be a new small new route to avoid breaking anything.

This was referenced Aug 21, 2021
@teolemon teolemon changed the title Create placeholder response if the product is present on Open Beauty Facts Create placeholder response if the product is present on Open (Beauty/PetFood/Products) Facts Aug 7, 2023
@teolemon teolemon added API READ All READ APIs include Product, Search… API Read - Product labels Sep 5, 2024
@teolemon
Copy link
Member Author

teolemon commented Sep 9, 2024

I'm adding the technical decision taken a while ago on universal product API @stephanegigandet @hangy @g123k : https://docs.google.com/document/d/1WPD23Jf-GMstjiK2gOZGayqECwxtucFqr7ijuyxDN4Q/edit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Read - Product API READ All READ APIs include Product, Search… API Refactor API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🎯 P1
Projects
Status: To discuss and validate
Status: To do
Status: To do
Status: To be triaged
Status: To Discuss & Validate
Development

No branches or pull requests

3 participants