Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static HTML files translated through CrowdIn do not have language specific CSS for rtl / ltr handling #6083

Open
Tracked by #5640
stephanegigandet opened this issue Nov 18, 2021 · 3 comments
Labels
RTL ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org

Comments

@stephanegigandet
Copy link
Contributor

Describe the bug

e.g. donation banner have this code:

<link
      rel="stylesheet"
      href="https://static.openfoodfacts.org/css/dist/app-ltr.css"
    />

For some languages like Arabic, we need to use app-rtl.css instead.

To Reproduce

See #6082

Expected behavior

Translated files work for both left to right and right to left languages.

Proposed solution: link to a dynamic CSS /cgi/css.pl that can use the subdomain of the page to apply the correct ltr or rtl setting of the corresponding language.

Screenshots

No response

Additional context

No response

Type of device

Browser

Browser version

No response

Number of products impacted

No response

Time per product

No response

@stephanegigandet stephanegigandet added 🐛 bug This is a bug, not a feature request. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org labels Nov 18, 2021
@stephanegigandet
Copy link
Contributor Author

Another option suggested by @alexgarel is to hardcode all subdomains with a RTL language and have a bit of JS to fetch the right CSS for those.

@teolemon teolemon added the RTL label Nov 18, 2021
@teolemon
Copy link
Member

teolemon commented Nov 18, 2021

@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Feb 17, 2022
@teolemon teolemon removed the 🐛 bug This is a bug, not a feature request. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RTL ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
Status: To discuss and validate
Development

No branches or pull requests

2 participants