Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "Unselect image" button translatable #6332

Closed
teolemon opened this issue Jan 22, 2022 · 2 comments · Fixed by #6570
Closed

Make the "Unselect image" button translatable #6332

teolemon opened this issue Jan 22, 2022 · 2 comments · Fixed by #6570
Labels
good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org untranslatable strings

Comments

@teolemon
Copy link
Member

What

Make the "Unselect image" button translatable

Code Pointer

Part of

@teolemon teolemon added Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org untranslatable strings labels Jan 22, 2022
@stephanegigandet stephanegigandet added the good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. label Apr 4, 2022
@stephanegigandet
Copy link
Contributor

We should use the lang() function, and the string needs to be added to po/common/common.pot and po/common/en.po
Once the po files are modified, the translations need to be rebuild using the build_lang.pl script in /scripts
(or make build_lang)

@yuktea
Copy link
Contributor

yuktea commented Apr 15, 2022

Fixed in PR #6570

@teolemon teolemon linked a pull request Apr 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org untranslatable strings
Projects
Development

Successfully merging a pull request may close this issue.

4 participants