Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eco-Score page on Spanish website is broken : https://es.openfoodfacts.org/ecoscore #7389

Closed
manon-corneille opened this issue Sep 22, 2022 · 5 comments
Assignees
Labels
🐛 bug This is a bug, not a feature request. 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 🎯 P1 static content This lives at https://github.com/openfoodfacts/openfoodfacts-web

Comments

@manon-corneille
Copy link
Contributor

Describe the bug

URL : https://es.openfoodfacts.org/ecoscore
bug - ecoscore -spain

To Reproduce

  1. Click on : https://es.openfoodfacts.org/producto/3229820019307/flocons-d-avoine-bjorg#panel_ecoscore
  2. Scroll down until you find the Eco-Score section
  3. Click on the Eco-Score hyperlink

Expected behavior

See the Eco-Score page in spanish

Screenshots

No response

Additional context

No response

Type of device

Browser

Browser version

No response

Number of products impacted

No response

Time per product

No response

@manon-corneille manon-corneille added the 🐛 bug This is a bug, not a feature request. label Sep 22, 2022
@alexgarel alexgarel self-assigned this Sep 23, 2022
@alexgarel
Copy link
Member

I'm looking at it, it might be because of a wrong redirection.

@alexgarel
Copy link
Member

It's not broken for de only but for maybe all countries !
It's because it uses the /ecoscore shortcut which redirection seems to redirect to french named uri…

@alexgarel
Copy link
Member

culprit is in ../off-server/conf/nginx/sites-available/off:

location = /ecoscore {
    return 301 https://$host/eco-score-l-impact-environnemental-des-produits-alimentaires;
}

while this one only exists in french…

@alexgarel
Copy link
Member

@manon-corneille it's fixed in prod, and I have a PR to keep the config.

@stephanegigandet should'nt we reflect of a more long term solution for those specific urls / redirect.
It would be nice
1- to translate every url
2- to have all those redirection handled in a flat file (maybe the map directive used on the uri https://nginx.org/en/docs/http/ngx_http_map_module.html)

@teolemon teolemon added static content This lives at https://github.com/openfoodfacts/openfoodfacts-web 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products labels Sep 26, 2022
@stephanegigandet
Copy link
Contributor

@stephanegigandet should'nt we reflect of a more long term solution for those specific urls / redirect.
It would be nice
1- to translate every url
2- to have all those redirection handled in a flat file (maybe the map directive used on the uri https://nginx.org/en/docs/http/ngx_http_map_module.html)

There's a proposal for a long term solution here: #1818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 🎯 P1 static content This lives at https://github.com/openfoodfacts/openfoodfacts-web
Projects
Development

No branches or pull requests

4 participants