Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the classic packaging field (packagings) in edit mode #7804

Closed
teolemon opened this issue Dec 6, 2022 · 3 comments · Fixed by #8500
Closed

Hide the classic packaging field (packagings) in edit mode #7804

teolemon opened this issue Dec 6, 2022 · 3 comments · Fixed by #8500
Labels
✏️ Editing ✨ Feature Features or enhancements to Open Food Facts server good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. Outreachy Good tasks for Outreachy applicants. See #productopener on our Slack https://slack.openfoodfacts.org 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling

Comments

@teolemon
Copy link
Member

teolemon commented Dec 6, 2022 •
edited
Loading

What

  • Hide the classic packaging field (packagings) in edit mode

Why

  • It's replaced by packaging_text and the new structured field

Part of
@teolemon teolemon added ✏️ Editing 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling ✨ Feature Features or enhancements to Open Food Facts server labels Dec 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Mar 7, 2023
@alexgarel alexgarel added the good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. label Mar 10, 2023
@MonalikaPatnaik
Copy link
Collaborator

Hey.. I would like to work on this issue..kindly tell me some pointers to fix it!
Thanks!

@yuktea yuktea assigned yuktea and unassigned yuktea Mar 10, 2023
@yuktea yuktea added the Outreachy Good tasks for Outreachy applicants. See #productopener on our Slack https://slack.openfoodfacts.org label Mar 10, 2023
@alexgarel
Copy link
Member

You can look at templates/web/pages/product_edit/product_edit_form_display.tt.html

where you see it uses display_fields_arr to get fields to display.

You can then search where this list is built.

@github-actions github-actions bot removed the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Mar 11, 2023
@MonalikaPatnaik MonalikaPatnaik mentioned this issue Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✏️ Editing ✨ Feature Features or enhancements to Open Food Facts server good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. Outreachy Good tasks for Outreachy applicants. See #productopener on our Slack https://slack.openfoodfacts.org 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling
Projects
Product Opener - Sprint
Status: 🔖 Sprint (max 10)
📦 Packaging improvements
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Hide the Classic Packaging Field in Edit Mode MonalikaPatnaik/openfoodfacts-server
4 participants
@alexgarel @teolemon @yuktea @MonalikaPatnaik