Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saturate fat errror inadvertently triggered #9305

Closed
aleene opened this issue Nov 13, 2023 · 1 comment · Fixed by #9463
Closed

Saturate fat errror inadvertently triggered #9305

aleene opened this issue Nov 13, 2023 · 1 comment · Fixed by #9463
Assignees
@benbenben2
Labels
🧽 Data quality - Nutrition 🧽 Data quality https://wiki.openfoodfacts.org/Quality

Comments

@aleene
Copy link
Contributor

aleene commented Nov 13, 2023

What

When a product has a saturated fat entry, but not a fat entry (empty or dash), the error Nutrition Saturated Fat greater than Fat is triggered.

Steps to reproduce the behavior

See https://nl.openfoodfacts.org/product/2255174002390/goud-en-eerlijk-volkoren-jumbo

Expected behavior

This should not produce an error.
@CharlesNepote CharlesNepote added the 🧽 Data quality https://wiki.openfoodfacts.org/Quality label Nov 15, 2023
@CharlesNepote
Copy link
Member

Good catch @aleene.

4000+ products have the corresponding error.

But many of these products has a saturated fat = 0.

2300+ products have Nutrition Saturated Fat greater than Fat and a saturated fat <> 0.

And 640+ of them don't have any photo.

@benbenben2 benbenben2 mentioned this issue Dec 1, 2023
Merged
@benbenben2 benbenben2 self-assigned this Dec 1, 2023
@benbenben2 benbenben2 moved this from To do to Needs review in 🧽 Ensuring Data Quality Dec 1, 2023
@benbenben2 benbenben2 moved this from In Progress to PRs in 🍊 Open Food Facts Server issues Dec 1, 2023
@github-project-automation github-project-automation bot moved this from Needs review to Done in 🧽 Ensuring Data Quality Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benbenben2 benbenben2

Labels
🧽 Data quality - Nutrition 🧽 Data quality https://wiki.openfoodfacts.org/Quality
Projects
🍊 Open Food Facts Server issues
Archived in project
🧽 Ensuring Data Quality
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Dq saturated fat only if fat defined openfoodfacts/openfoodfacts-server
3 participants
@CharlesNepote @aleene @benbenben2