Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend knowledge API to specify which panels should be returned or excluded #9369

Closed
Tracked by #4842
stephanegigandet opened this issue Nov 22, 2023 · 0 comments · Fixed by #10701
Closed
Tracked by #4842

Extend knowledge API to specify which panels should be returned or excluded #9369

stephanegigandet opened this issue Nov 22, 2023 · 0 comments · Fixed by #10701
Labels
📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🤳🥫 mobile apps 🎯 P1

Comments

@stephanegigandet
Copy link
Contributor

stephanegigandet commented Nov 22, 2023 •
edited by teolemon
Loading

Similar to the fields parameter, we could have a parameter to specify which knowledge panels to return (and/or possibly to do the reverse: exclude some panels).

Example

  • knowledge_panels_included=toto,tata,titi

Related

  • Moderator KP
  • Experimental KPs

Part of
This was referenced Nov 24, 2023
Open
Open
@teolemon teolemon added the 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels label Dec 1, 2023
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@4nt0ineB 4nt0ineB mentioned this issue Aug 14, 2024
Merged
4nt0ineB added a commit that referenced this issue Aug 21, 2024
@4nt0ineB @teolemon @alexgarel
feat: knowledge API to specify which panels should be returned (#10701)
384961a 
<!-- IMPORTANT CHECKLIST
Make sure you've done all the following (You can delete the checklist
before submitting)
- [ ] PR title is prefixed by one of the following: feat, fix, docs,
style, refactor, test, build, ci, chore, revert, l10n, taxonomy
- [ ] Code is well documented
- [ ] Include unit tests for new functionality
- [ ] Code passes GitHub workflow checks in your branch
- [ ] If you have multiple commits please combine them into one commit
by squashing them.
- [ ] Read and understood the [contribution
guidelines](https://github.com/openfoodfacts/openfoodfacts-server/blob/main/CONTRIBUTING.md)
-->
### What

Added a `knowled_panels_included=x,y` and `knowled_panels_excluded=x,y`
parameter to the API, to specify which panels should be in the response.

### Related issue(s) and discussion
<!-- Please add the issue number this issue will close, that way, once
your pull request is merged, the issue will be closed as well -->
- Fixes #9369

---------

Co-authored-by: Pierre Slamich <[email protected]>
Co-authored-by: Alex Garel <[email protected]>
@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Aug 21, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in 📖 Knowledge panels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🤳🥫 mobile apps 🎯 P1
Projects
🍊 Open Food Facts Server issues
Archived in project
📖 Knowledge panels
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: knowledge API to specify which panels should be returned 4nt0ineB/openfoodfacts-server
2 participants
@teolemon @stephanegigandet