Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dutch data quality facet gives wrong results #9397

Closed
aleene opened this issue Nov 24, 2023 · 12 comments · Fixed by openfoodfacts/openfoodfacts-query#27
Closed

Dutch data quality facet gives wrong results #9397

aleene opened this issue Nov 24, 2023 · 12 comments · Fixed by openfoodfacts/openfoodfacts-query#27
Labels
🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🎯 P1

Comments

@aleene
Copy link
Contributor

aleene commented Nov 24, 2023

What

Dutch data quality facet gives wrong results. Instead of showing the errors for NL-products, the errors for the world are shown.

Steps to reproduce the behavior

See https://nl.openfoodfacts.org/data-quality-errors

Expected behavior

Only see the dutch errors

@teolemon teolemon added 🐛 bug This is a bug, not a feature request. 🎯 P1 🧽 Data quality https://wiki.openfoodfacts.org/Quality labels Nov 24, 2023
@CharlesNepote
Copy link
Member

Same or similar issue happens on https://world.openfoodfacts.org/data-quality-errors with errors that are not errors but only warnings.

@alexgarel
Copy link
Member

@john-gom any idea ?

@john-gom
Copy link
Contributor

I think the queries are returning the right data - https://nl.openfoodfacts.org/data-quality-errors is returning less data than https://world.openfoodfacts.org/data-quality-errors and I can see that the country is being restricted to en:netherlands for the "nl" query.

@aleene
Copy link
Contributor Author

aleene commented Dec 13, 2023

Still strange, so much different than what we had before. Note that none(?) of the entries contain any products.

@CharlesNepote
Copy link
Member

@john-gom: I don't know where is the issue but I can say that /data-quality-errors are completely false.

https://world.openfoodfacts.org/data-quality-errors or https://nl.openfoodfacts.org/data-quality-errors are returning not only data quality errors but also data quality warnings, which are different.

Example: Food groups 3 unknown (the first in the list) is NOT a data-quality-error and should not be listed here. Maybe that's why Food groups 3 unknown is empty?

Here are the data quality errors: https://wiki.openfoodfacts.org/List_of_data_quality_errors_(generated)

@john-gom
Copy link
Contributor

Hi @CharlesNepote . I'll have to investigate whether the problem is at the source or is being introduced in off-query

@john-gom
Copy link
Contributor

OK, I see the problem. The data_quality and data_quality_errors tags have been transposed. I'll see if I can get a PR raised as soon as possible

@aleene
Copy link
Contributor Author

aleene commented Dec 19, 2023

Not yet the result as expected:

  • counts seem wrong;
  • no products shown (related to counts?);
  • no way to zoom in on errors (and leave warnings aside)

@john-gom
Copy link
Contributor

Hi @CharlesNepote , @aleene . This should not be resolved in Staging. Can you check that the figures look right now? https://nl.openfoodfacts.net/data-quality-errors

@CharlesNepote
Copy link
Member

Yes that's fine @john-gom, thank you very much!

@john-gom
Copy link
Contributor

@CharlesNepote , @aleene this has now been deployed to production.

@github-project-automation github-project-automation bot moved this from In progress to Done in 🧽 Ensuring Data Quality Jan 18, 2024
@CharlesNepote
Copy link
Member

Works great, thanks @john-gom !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🎯 P1
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants