Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an API route to provide Quality Warnings and Errors on a given nutrition table/ingredients list #9710

Open
Tracked by #10272
teolemon opened this issue Jan 29, 2024 · 3 comments · May be fixed by #10129
Open
Tracked by #10272

Comments

@teolemon
Copy link
Member

teolemon commented Jan 29, 2024

What

Even for new products, we could send values to a To be created™ route, that could send back potential errors and warnings in real time

Part of

Originally posted by @teolemon in openfoodfacts/smooth-app#3978 (comment)

@teolemon teolemon changed the title Create an API route to provide Quality Facets on a nutrition table Create an API route to provide Quality Warnings and Errors on a given nutrition table/ingredients list Jan 29, 2024
@teolemon teolemon added ✨ Feature Features or enhancements to Open Food Facts server 🧽 API - Quality labels Feb 8, 2024
@IsaiahLevy
Copy link

Can I work on this?

@stephanegigandet
Copy link
Contributor

@IsaiahLevy Sure!

Some comments about this issue:

We are building a "product services" API that allows to run specific services (such as analyzing the ingredient list) on product data that is provided as input to the API. There is a test file to demonstrate some of that: https://github.com/openfoodfacts/openfoodfacts-server/blob/main/tests/integration/api_v3_product_services.t

So for this issue, the best solution would be to create a "check_quality" service that would run the quality checks from lib/ProductOpener/DataQuality.pm and send back the related data_quality_*_tags fields.

The code for the existing product services is in https://github.com/openfoodfacts/openfoodfacts-server/blob/main/lib/ProductOpener/APIProductServices.pm

@teolemon
Copy link
Member Author

I'm bumping this one to P1, as it would be useful to many apps (ours, Macrofactor; Foodvisor…)

@teolemon teolemon removed the ✨ Feature Features or enhancements to Open Food Facts server label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To discuss and validate
Status: To do
Development

Successfully merging a pull request may close this issue.

3 participants