Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring data changes #9777

Open
aleene opened this issue Feb 9, 2024 · 4 comments
Open

Monitoring data changes #9777

aleene opened this issue Feb 9, 2024 · 4 comments
Labels
Checked products 🧽 Data quality https://wiki.openfoodfacts.org/Quality

Comments

@aleene
Copy link
Contributor

aleene commented Feb 9, 2024

What

I am trying to look at all data quality errors for the Netherlands, in order to see how many can repaired and to know the intrinsic errors made my producers on packages.

So I look at the page with errors: https://nl.openfoodfacts.org/data-quality-errors and go through all products. If a product is done I add a checkmark on the checkmarks at the bottom: images have been checked:
Screenshot 2024-02-09 at 09 32 47

After doing a initial run through all the products I like to follow any newly introduced erros by looking at: https://nl.openfoodfacts.org/status/-foto-s-gecontroleerd/data-quality-errors/ This is the same a the previous list but now enhances with the facet photos checked not checked (made negative with a "-").

This does not work. Why not?

Steps to reproduce the behaviour

see the list

Expected behaviour

I like to see only the products that I did not look atr

@teolemon teolemon added 🧽 Data quality https://wiki.openfoodfacts.org/Quality Checked products 🐛 bug This is a bug, not a feature request. labels Feb 15, 2024
@himanshisrestha
Copy link
Contributor

is this issue is only visible on the pro platform , I was not able to view the issue after clicking the link. @aleene

@aleene
Copy link
Contributor Author

aleene commented Mar 22, 2024

Not sure this solved or not. It might be related to the cache that has some issues.

@aleene
Copy link
Contributor Author

aleene commented Apr 1, 2024

is this issue is only visible on the pro platform

It is nothing to do with the pro platform. It is about the usage of the checkbox 'product has been checked'

@aleene
Copy link
Contributor Author

aleene commented Oct 11, 2024

The example given is for monitoring data quality errors, but is valid for any set of products. Once a product is set to checked we would like to know if any changes are made, either simple edits or new images. This might require to look at the product again. Thus we can keep an eye on product groups (categories, quality errors, products created since a date, etc.). In the code the value for checked is linked to the state for completed:

if ($complete) {
        push @states_tags, "en:complete";
        if ((defined $product_ref->{checked}) and ($product_ref->{checked} eq 'on')) {
            push @states_tags, "en:checked";
        }
        else {
            push @states_tags, "en:to-be-checked";
        }
    }
    else {
        push @states_tags, "en:to-be-completed";
    }

My proposal is to decouple these states. Completed is to specify that all the data (which) has been filled in; Checked is to specify that all possible data has been extracted from the images.

@aleene aleene changed the title Monitoring data quality todos Monitoring data changes Oct 11, 2024
@teolemon teolemon removed the 🐛 bug This is a bug, not a feature request. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Checked products 🧽 Data quality https://wiki.openfoodfacts.org/Quality
Projects
Status: To discuss and validate
Status: To do
Development

No branches or pull requests

3 participants