Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account removal is broken #9820

Closed
alexgarel opened this issue Feb 21, 2024 · 1 comment · Fixed by #9769
Closed

Account removal is broken #9820

alexgarel opened this issue Feb 21, 2024 · 1 comment · Fixed by #9769
Labels
Account deletion Enabling users to delete account while preserving accountability for edits 🐛 bug This is a bug, not a feature request. JavaScript 🎯 P0

Comments

@alexgarel
Copy link
Member

One user told us he can't click on the remove my account button.

The user.pl javascript seems broken.

If the console:
Uncaught SyntaxError: missing ) after argument list

@teolemon teolemon added Account deletion Enabling users to delete account while preserving accountability for edits 🐛 bug This is a bug, not a feature request. labels Feb 21, 2024
@alexgarel
Copy link
Member Author

I did a hotfix in prod with [% lang("delete_confirmation") | replace("'", "\'") %].

The complete fix is #9822

alexgarel added a commit that referenced this issue Mar 6, 2024
Translations coming from crowdin might contain single quotes or double quotes. So whenever we use lang in a json or javascript string we should escape quotes.

I created edq and esq (Escape Single/Double Quotes) function for that (1st commit) and applied it in a lot of place (2nd commit). This should be the pattern to use from now on. 

fixes: 
- #9820
john-gom pushed a commit that referenced this issue May 24, 2024
Translations coming from crowdin might contain single quotes or double quotes. So whenever we use lang in a json or javascript string we should escape quotes.

I created edq and esq (Escape Single/Double Quotes) function for that (1st commit) and applied it in a lot of place (2nd commit). This should be the pattern to use from now on. 

fixes: 
- #9820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Account deletion Enabling users to delete account while preserving accountability for edits 🐛 bug This is a bug, not a feature request. JavaScript 🎯 P0
Projects
None yet
2 participants