Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account obsolete collection #1095

Open
alexgarel opened this issue Apr 18, 2023 · 2 comments
Open

Take into account obsolete collection #1095

alexgarel opened this issue Apr 18, 2023 · 2 comments

Comments

@alexgarel
Copy link
Member

alexgarel commented Apr 18, 2023

On product opener side We now move obsolete products to their own collection (see openfoodfacts/openfoodfacts-server#8277)

So on robotoff side, when we look for a product in mongodb we should check for both collection: the regular collection (products) and the obsolete one (products_obsolete).

Part of

@raphael0202
Copy link
Collaborator

We also check every night that insights are still valid using product dump, it's sure that the obsolete products are still in the JSONL product dump?

@alexgarel
Copy link
Member Author

It's sure that the obsolete products are still in the JSONL product dump?

No they are not (yet).

That said @stephanegigandet thinks obsolete products are less than 5 000 so it's not that a priority.

@teolemon teolemon removed the 🐛 bug Something isn't working label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants