Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve perf random logo search #1397

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

raphael0202
Copy link
Collaborator

Fixes #1386.

We use the newly indexed column logo_annotation.server_type to filter logos of a specific server_type.
Note that the sampling fraction we've chosen (20%) may not be adapted depending on how infrequent a certain server_type is. Currently, we only have logos with server_type=off, so we can keep it this way.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.06%. Comparing base (a318737) to head (7f65d10).

Files Patch % Lines
robotoff/app/api.py 0.00% 4 Missing ⚠️
robotoff/cli/main.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1397      +/-   ##
==========================================
- Coverage   56.06%   56.06%   -0.01%     
==========================================
  Files          80       80              
  Lines        8010     8011       +1     
==========================================
  Hits         4491     4491              
- Misses       3519     3520       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphael0202 raphael0202 merged commit 8251082 into main Aug 20, 2024
9 of 11 checks passed
@raphael0202 raphael0202 deleted the improve-perf-random-logo-search branch August 20, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Rewrite the query used by Hunger Games to fetch random logos
2 participants